Alter an existing MySQL column to a JSON data type
Asked Answered
V

1

12

I am trying to change a MySQL column from varchar(9000) NULL to the new JSON data type in MySQL 5.7. The column holds valid JSON strings but some values are null. When I try the following:

alter table log modify request json

it fails with the following error:

Invalid JSON text: "The document is empty." at position 0 in value for column '#sql-2f36_168a6.request'

However, when I create a new column:

alter table log add request_json json

and then insert the same data:

update log set request_json=json where request != ''

the new request_json column is updated. How to I modify the existing column to JSON data type and preserve the JSON data without creating a new column?

Vicennial answered 14/6, 2016 at 12:51 Comment(3)
You difference in your column between NULL and ''?. Run SELECT `log` FROM `request` WHERE JSON_VALID(`log`)=0\G to detect those rows that can cause problems.Pre
I ran your query and found a few hundred with null or blank values. is NULL invalid for json Data types?Vicennial
so after playing with it a bit more it seems that NULL is valid but having a blank value is invalid. Does that ring true?Vicennial
P
15

12.6 The JSON Data Type

...

  • Automatic validation of JSON documents stored in JSON columns. Invalid documents produce an error.

...

mysql> SHOW CREATE TABLE `log`\G
*************************** 1. row ***************************
       Table: log
Create Table: CREATE TABLE `log` (
  `request` json DEFAULT NULL
) ENGINE=InnoDB
1 row in set (0,00 sec)

mysql> SELECT `request`, JSON_VALID(`request`)
    -> FROM `log`;
+-----------------+-----------------------+
| request         | JSON_VALID(`request`) |
+-----------------+-----------------------+
| {"type": "bug"} |                     1 |
| NULL            |                  NULL |
| NULL            |                  NULL |
+-----------------+-----------------------+
3 rows in set (0,00 sec)

mysql> UPDATE `log`
    -> SET `request` = ''
    -> WHERE `request` IS NULL;
ERROR 3140 (22032): Invalid JSON text: "The document is empty." at position 0 in value for column 'log.request'.

Try:

mysql> DROP TABLE IF EXISTS `log`;
Query OK, 0 rows affected (0,00 sec)

mysql> CREATE TABLE IF NOT EXISTS `log` (
    ->   `request` VARCHAR(9000) NULL
    -> );
Query OK, 0 rows affected (0,01 sec)

mysql> INSERT INTO `log`
    ->   (`request`)
    -> VALUES
    ->   ('{"type": "bug"}'),
    ->   (NULL),
    ->   ('');
Query OK, 3 rows affected (0,00 sec)
Records: 3  Duplicates: 0  Warnings: 0

mysql> SELECT `request`, JSON_VALID(`request`)
    -> FROM `log`;
+-----------------+-----------------------+
| request         | JSON_VALID(`request`) |
+-----------------+-----------------------+
| {"type": "bug"} |                     1 |
| NULL            |                  NULL |
|                 |                     0 |
+-----------------+-----------------------+
3 rows in set (0,00 sec)

mysql> ALTER TABLE `log` MODIFY `request` JSON;
ERROR 3140 (22032): Invalid JSON text: "The document is empty." at position 0 in value for column '#sql-1bab_4.request'.

mysql> UPDATE `log`
    -> SET `request` = NULL
    -> WHERE `request` = '';
Query OK, 1 row affected (0,00 sec)
Rows matched: 1  Changed: 1  Warnings: 0

mysql> ALTER TABLE `log` MODIFY `request` JSON;
Query OK, 3 rows affected (0,00 sec)
Records: 3  Duplicates: 0  Warnings: 0

mysql> SELECT `request`, JSON_VALID(`request`)
    -> FROM `log`;
+-----------------+-----------------------+
| request         | JSON_VALID(`request`) |
+-----------------+-----------------------+
| {"type": "bug"} |                     1 |
| NULL            |                  NULL |
| NULL            |                  NULL |
+-----------------+-----------------------+
3 rows in set (0,00 sec)

mysql> SHOW CREATE TABLE `log`\G
*************************** 1. row ***************************
       Table: log
Create Table: CREATE TABLE `log` (
  `request` json DEFAULT NULL
) ENGINE=InnoDB
1 row in set (0,00 sec)
Pre answered 14/6, 2016 at 19:13 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.