What you're describing (and what you've more or less reinvented in your implementation with foldLeft
and ~
) is essentially Haskell's sequence
for monads (really you only need an applicative functor, but that's irrelevant here). sequence
takes a list of monadic values and returns a monadic list of values. Parser
is a monad, so sequence
for Parser
would change a List[Parser[A]]
into a Parser[List[A]]
.
Scalaz gives you sequence
, but off the top of my head I don't know if there's a nice way to get the necessary Applicative
instance for Parser
. Fortunately you can roll your own pretty easily (I'm directly translating the Haskell definition):
import scala.util.parsing.combinator._
object parser extends RegexParsers {
val integer = """\d+""".r
val counts = List(1, 2, 3)
val parsers = counts.map(repN(_, integer))
val line = parsers.foldRight(success(Nil: List[List[String]])) {
(m, n) => for { x <- m ; xs <- n } yield (x :: xs)
}
def apply(s: String) = parseAll(line, s)
}
This gives us List(List(1), List(2, 3), List(4, 5, 6))
for parser("1 2 3 4 5 6")
, as desired.
(Note that I'm using RegexParsers
here as a convenient complete example, but the approach works more generally.)
What's going on might be a little clearer if we desugar the for
comprehension:
val line = parsers.foldRight(success(Nil: List[List[String]])) {
(current, acc) => current.flatMap(x => acc.map(x :: _))
}
We can write flatMap
as into
and map
as ^^
:
val line = parsers.foldRight(success(Nil: List[List[String]])) {
(current, acc) => current into (x => acc ^^ (x :: _))
}
This isn't too far from your formulation, except that we're using a right fold instead of reversing and aren't building up and breaking down the ~
s.
About efficiency: Both of our implementations are going to result in unpleasant call stacks. In my experience this is just a fact of life with Scala's parser combinators. To quote another Stack Overflow answer, for example:
Scala's parser combinators aren't very efficient. They weren't
designed to be. They're good for doing small tasks with relatively
small inputs.
My sequence
-y approach addresses the "more readable" part of your question, and is almost certainly the cleanest way to solve the problem with Scala's parser combinators. It's marginally more efficient than your implementation, and should be fine for a few thousand groups or so. If you need to handle more than that, you'll have to look outside of scala.util.parsing.combinator
. I'd recommend something like the following:
def parse(counts: Seq[Int], input: String): Option[Seq[Seq[Int]]] = {
val parsed = try {
Some(input.split(" ").map(_.toInt))
} catch {
case _ : java.lang.NumberFormatException => None
}
parsed.flatMap { ints =>
if (ints.length != counts.sum) None
else Some(counts.foldLeft((Seq.empty[Seq[Int]], ints)) {
case ((collected, remaining), count) => {
val (m, n) = remaining.splitAt(count)
(m.toSeq +: collected, n)
}
}._1.reverse)
}
}
No guarantees, but on my system it doesn't overflow on a line with 100k integer groups.
repN
are implemented using a while loop. Could I get stack overflow for very long sequences using my or your implementation? – Imogen