Why isvalid("integer","1,5") = YES?

Asked 18/7, 2012 at 7:6 Answered 8/8, 2016 at 18:37

Solved validation coldfusion integer coldfusion-9

Why does #isValid("integer","1,5")# output YES? I expected it to output NO like #isValid("integer","1.5")# does.

I'm going to validate with <CFIF isvalid("integer","1,5") AND isnumeric("1,5")> ...

Oxidation answered 18/7, 2012 at 7:6 Comment(1)

meanwhile, use cflib.org/udf/IsInt :) – Komsomolsk 20/7, 2012 at 18:44

Adobe is aware of this, but...

State: Closed

Status: Withdrawn

Reason: AsDesigned

https://bugbase.adobe.com/index.cfm?event=bug&id=3169196

TBH I'm a little embarrassed to be using a language that can't even validate integer correctly.

UPDATE:

Guess what, it'll be addressed in CF12!

There is no doubt that this behavior is incorrect. It is obviously wrong and it should be corrected. However, it has been like this forever and making such a fundamental change has a great potential to break a lot of applications. We dont want to do that in this release. As Rakshith has already communicated, we plan to take up such changes in 'Dazzle' where we will correct the behavior without worrying about backward compatibility.

http://blog.adamcameron.me/2014/02/can-we-please-agree-that-adobe-is-not.html

Komsomolsk answered 18/7, 2012 at 7:58 Comment(1)

I too am embarrassed - and blaming not fixing a cf8 bug for backwards compatibility reasons? Really? If the function is broken, people won't use it. Who's old code exactly are they trying to maintain? – Plantagenet 18/7, 2012 at 10:24

Just to expand on the answer here and explain what's actually going on.

See this related bug, a summary of the detail of which is that CF will interpret "m,n" (where m and n are digits) as a DATE if it possibly can. This is ludicrous: "m,n" is not a format that represents a date to anyone on the planet, so there is no reason for CF to ever interpret it this way.

Adobe copped-out of fixing this issue to, citing the same excuse that it would break backwards compat. Nonsense it would.

Anyway... because a date can be cast to an integer in CF, CF thinks "1,5" is a legit integer, because it's actually a date. How embrrassing it is - as a dedicated CF developer - to have to offer you than explanation. Sorry.

Pete answered 18/7, 2012 at 11:31 Comment(8)

Agreed. In a typeless language, it makes even more sense to have rock-solid type checking when you want/need it. – Vallee 18/7, 2012 at 12:55

I bet Rupesh @ Adobe still uses IE6 – Plantagenet 19/7, 2012 at 0:8

Cf thinks the string '0,6' == '6,0'. I don't want to live on this planet anymore – Plantagenet 19/7, 2012 at 0:17

'0,6' == '6,0' TRUE... '12,31' == '31,12' TRUE... '12,6' == '6,12' FALSE... '1,6' == '6,1' FALSE... Oh god, why? – Plantagenet 19/7, 2012 at 1:33

I'm trying to gather some stats as to the community reaction to all this, which I will get to Adobe somehow. If poss, it'd be handy if you could have a look at this article that I knocked together (adamcameroncoldfusion.blogspot.co.uk/2012/07/…), and this survey (surveymonkey.com/s/JN5X8TS). – Pete 19/7, 2012 at 10:51

Found another bug... '12a' + 0 == 0. '12b' + 0 == throw "The value 12b cannot be converted to a number". isNumeric( '12a' ) == false. What gives? – Plantagenet 9/8, 2012 at 12:15

If I had to guess I would sat 12a is being interpreted as 12am :-(. Not in front of a CF machine just now, so cannae test, sorry. – Pete 10/8, 2012 at 19:43

@AdamCameron What about this #19140719 ? – Circumfuse 2/10, 2013 at 15:27

If you want to make absolutely sure you have an Integer, you could use Java Integer methods.

<cfscript>
createObject("java","java.lang.Integer").parseInt("1,5");
</cfscript>

The parseInt() method throws when it is given anything that cannot be interpreted as an Integer. This includes "1,5".

Plantagenet answered 18/7, 2012 at 10:32 Comment(8)

Nice! Thank you. But now I wonder if isvalid("integer","1,5") AND isnumeric("1,5") miss some cases which I did not consider where the input is not an integer. – Oxidation 18/7, 2012 at 10:46

Hmm, with an additional java object proxy and cftry/catch needed for checking if something's an integer? – Komsomolsk 18/7, 2012 at 16:45

Henry - yes, you'd need to wrap it with a try/catch. It's not a perfect solution by any means, but will ensure your value is an Integer. We tend to write java utility libraries for simple tasks like this and persist them in the application scope as createObject can get expensive. If you saw what was inside isValid() + isNumeric(), you probably would too :) – Plantagenet 19/7, 2012 at 0:6

I like function isInteger(num) {return refind("^\d+$", num);} better. :) – Komsomolsk 2/8, 2012 at 23:38

You could even leverage CF's duck typing everything to a string and use the java String matches. eg. num.matches('\d+') ? num : 0; which would default it to zero when not a sequence of numbers – Plantagenet 9/8, 2012 at 12:11

@Henry, nice one, I used the same with one minor addition, to allow for negative numbers too: "^-?\d+$" – Jadwiga 26/9, 2013 at 10:50

<cfif isNumeric(num) and not num contains '.'> returns true on integer value otherwise false – Tumefacient 9/5, 2016 at 11:37

Recommend adding some additional logic so that BigInts aren't considered valid Ints. return refind("^-?\d+$", num) AND VAL(num) LTE 2147483647 AND VAL(num) GTE -2147483647 – Herby 29/12, 2016 at 23:51

Server side validation (only need the cfif logic, loop for example only)

<cfloop list="2.123,a,4" index="myVal">
    <cfif !isNumeric(myVal)> ...error code for not numeric<br />
    <cfelseif myVal neq int(myVal)> ...error code for not integer<br />
    <cfelse>is integer<br />
    </cfif>
</cfloop>

Tighter direct code:

<cfif !isNumeric(myVal) and myVal neq int(myVal)> ...error code for not integer<br />
</cfif>

You could write a cffunction as well

Electrobiology answered 8/8, 2016 at 18:37 Comment(0)

Recommended topics

Hot tags