Finishactivity doesn't finish the activity?

Question

I'm trying to get my activity to close and return with the result, I do have onActivityResult in my parent activity, and I have used close to the same method below in other places where it works.

public void deleteFile(){
        boolean deleted=FileManager.getInstance().deleteMeasurementData(this.getIntent().getData(), this);
        if(deleted){
            Toast.makeText(this, originalData.getName() +".mmd Has been deleted", Toast.LENGTH_SHORT);
            setResult(EditMeasurement.RESULT_YES_DELETED);
            finishActivity(EditMeasurement.RESULT_YES_DELETED);
        }else {
            Toast.makeText(this, originalData.getName() +".mmd did NOT delete", Toast.LENGTH_SHORT);
            Log.e(TAG, "File did NOT delete error");
        }

    }

This method was called from this menu :

public boolean onOptionsItemSelected(MenuItem item) {
        // Handle item selection
        Log.i(TAG, "something choosen "+item.getItemId()+" it should have been: "+R.id.om_measurement_menu_delete);

        switch (item.getItemId()) {
        case R.id.om_measurement_menu_edit:
            editFile();
            return true;
        case R.id.om_measurement_menu_delete:
            deleteFile();
            return true;
        case R.id.om_measurement_menu_cancel:
            endActivity();
            return true;
        default:
            return super.onOptionsItemSelected(item);
        }
    }

Anyone with any bright ideas why it doesnt close?

Farrah

Just put finish() in deleteFile() and let me know what happen.. – Mendenhall

Answer 1

finishActivity is used to close another activity from current - http://developer.android.com/reference/android/app/Activity.html#finishActivity(int), so just change it to finish();

Centrosymmetric

Answer 2

I had it as finish() even with a return but it wouldn't close, then I realized that that particular Activity needed the android:launchMode="singleTask" in the Manifest

Willianwillie

IMO, this answer should've been either a comment or an edition to the accepted answer since it seems to be a valuable contribution. Yet, the poster didn't have enough reputation to comment, and editing an answer is something many people would not dare do (myself included, I prefer suggestions in comments). – Dieselelectric