Log4j and AOP, how to get actual class name

Question

I'm implementing a logger as an aspect using Spring AOP and Log4J, but I've noticed that the class name in log file is always the LoggerAspect class name, so... is there a way to trace the actual class name in my log?

Adlay

Can you make it part of the message itself? – Aport

See also: Spring: Standard Logging aspect (interceptor) – Bijou

Answer 1

@Around("execution(* com.mycontrollerpackage.*.*(..))")
public Object aroundWebMethodE(ProceedingJoinPoint pjp) throws Throwable {      
    String packageName = pjp.getSignature().getDeclaringTypeName();
    String methodName = pjp.getSignature().getName();
    long start = System.currentTimeMillis();
    if(!pjp.getSignature().getName().equals("initBinder")) {
       logger.info("Entering method [" + packageName + "." + methodName +  "]");
    }
    Object output = pjp.proceed();
    long elapsedTime = System.currentTimeMillis() - start;
    if(!methodName.equals("initBinder")) {
       logger.info("Exiting method [" + packageName + "." + methodName + "]; exec time (ms): " + elapsedTime);
    }
    return output;
}

Isobath

This even works for proxied classes (the non-proxied name is shown in the log message). – Flan

Answer 2

this is easier:

pjp.getTarget().getClass()

Rumormonger

But one problem ProceedingJoinPoint is only supported for around advice only not for Before or After – Swaim

Answer 3

Use : pjp.getTarget().getClass().getCanonicalName()

Also, to add logs at class level of which method is being exexuted instead using logger of advice class, use class level logger within advice method, as below

Logger logger = Logger.getLogger(pjp.getTarget().getClass().getCanonicalName());

Heaton

This is not a good practice i.e. asking for logger object for every advice method call. – Shithead

Good point @Mohit, but Slf4J has an implementation of having all the logger objects cached, so it's not a significant overhead. – Stay