Volley not calling getParams() for standard POST request

Question

I am trying to post some parameters to my rails API using Volley in Android. This is the code:

I tried with two log statements, one in getParams() and another in getHeaders(). The one in getHeaders() is logged while the other one is not. Why is volley ignoring getParams()?

{
//full_name,email,password are private variables defined for this class

String url =  "http://10.0.2.2:3000/users/sign_up.json" ; 

JsonObjectRequest jsonObjReq = new JsonObjectRequest(Request.Method.POST,
                 url, null,
                 new Response.Listener<JSONObject>() {

                     @Override
                     public void onResponse(JSONObject response) {
                         Log.d(TAG, response.toString());
                         pDialog.hide();
                     }
                 }, new Response.ErrorListener() {

                     @Override
                     public void onErrorResponse(VolleyError error) {
                         VolleyLog.d(TAG, "Error: " + error.getMessage());
                         pDialog.hide();
                     }
                 }) {

             @Override
             public Map<String, String> getParams() {
                 Map<String, String> params = new HashMap<String, String>();

                 //This does not appear in the log
                 Log.d(TAG,"Does it assign params?") ;


                 params.put("name", full_name.getText().toString());
                 params.put("email",email.getText().toString());
                 params.put("password", password.getText().toString());

                 return params;
             }
             @Override
             public Map<String, String> getHeaders() throws AuthFailureError {

                 //This appears in the log  
                 Log.d(TAG,"Does it assign headers?") ;

                 HashMap<String, String> headers = new HashMap<String, String>();
                 headers.put("Content-Type", "application/json; charset=utf-8");

                 return headers;
             }

         };

        // Adding request to request queue
        VHelper.getInstance().addToRequestQueue(jsonObjReq, tag_json_obj);

}

Casuistry

It's quite easy to solve, check my answer here. – Serna

Answer 1

Using StringRequest in place of JsonObjectRequest

StringRequest sr = new StringRequest(Request.Method.POST, url , new Response.Listener<String>() {
        @Override
        public void onResponse(String response) {
            Log.d(TAG, response.toString());
        }
    }, new Response.ErrorListener() {
        @Override
        public void onErrorResponse(VolleyError error) {
            VolleyLog.d(TAG, "Error: " + error.getMessage());
            Log.d(TAG, ""+error.getMessage()+","+error.toString());
        }
    }){
        @Override
        protected Map<String,String> getParams(){
            Map<String, String> params = new HashMap<String, String>();
            params.put("id", "28");
            params.put("value", "1");

            return params;
        }

        @Override
        public Map<String, String> getHeaders() throws AuthFailureError {
            Map<String,String> headers = new HashMap<String, String>();
            headers.put("Content-Type","application/x-www-form-urlencoded");
            headers.put("abc", "value");
            return headers;
        }
    };

        AppController.getInstance().addToRequestQueue(sr);

Izmir

I can't believe this was it. I was using a JSONObjectRequest and the debugger never hit the getParams() method, so no POST params. The moment i changed to StringRequest the debugger hit the getParams(). ¬_¬ – Corruption

Thanks, you saved my day. Is there a reason why for JsonObjectRequest the overloaded getParams method is not getting invoked ? – Incredulous

The JsonObjectRequest is extended JsonRequest which override getBody() method directly, so your getParam() would never invoke, – Balneology

thumbs up if you too got the problem – Breathy

Can someone post the reason why JSONObjectRequest is not hitting getParams() but StringRequest is? – Ivyiwis

Answer 2

The third parameter should be a JSONObject you do not need the getParams() method just pass them into the request.

 JsonObjectRequest jsonObjReq = new JsonObjectRequest(
            method,
            url,
            jsonObjParams,    // <<< HERE
            responseListener,
            errorListener);

Ancillary

Hi sir, what if i will pass two parameters? how can i put it on the third parameters of JsonObjectRequest.? – Confine

This will require setting up the server to support POST data in JSON format. In PHP, that would mean doing something like this. – Tactless

Answer 3

it happened because Volley params cache.

clean it like this

requestQueue.getCache().clear();

hope it's useful!😃

Epiphora

I tried this but didn't work to solve the issue of getParams() not being called. \n\n RequestQueue queue = Volley.newRequestQueue(this); queue.getCache().clear(); – Reahard

Answer 4

I solved my issue by simply removing Content-Type from header :)

Adamina

Answer 5

Please override the getBody() method, and if your server can not handle JSON request parameter, you have to override the getHeaders() method to change your Content-Type.

Issue can found here: https://github.com/mcxiaoke/android-volley/issues/82

Diatribe

Answer 6

For JSONobjectRequest the getParams() doesn’t work for POST requests so you have to make a customRequest and override getParams() method over there. Its because JsonObjectRequest is extended JsonRequest which overrides getBody() method directly, so your getParam() would never invoke. To invoke your getParams() method you first have to override getBody(). Or for a simple solution you can use StringRequest.

Gimel

Answer 7

Try using shouldCache(false) for your request object before you add it into queue.

Schulze

Answer 8

To provide POST parameter build a JSONObject with your POST parameters and pass that JSONObject as a 3rd parameter. JsonObjectRequest constructor accepts a JSONObject in constructor which is used in Request Body.

JSONObject paramJson = new JSONObject();

paramJson.put("key1", "value1");
paramJson.put("key2", "value2");


JsonObjectRequest jsonObjectRequest = new JsonObjectRequest(Request.Method.POST,url,paramJson,
    new Response.Listener<JSONObject>() {
        @Override
        public void onResponse(JSONObject response) {

        }
    },
    new Response.ErrorListener() {
        @Override
        public void onErrorResponse(VolleyError error) {

        }
    });
requestQueue.add(jsonObjectRequest);

Mercie

Answer 9

I had the same problem I solved it using clear queue Cache

RequestQueue requestQueue = Volley.newRequestQueue(this);
requestQueue.getCache().clear();
requestQueue.add(stringRequest);

Remnant

Answer 10

just use requestQue.getCache().clear();

Feu

Answer 11

If you do a Post using Android Volley, it should call the methods getHeaders(), getBody(), getParams(), and getBodyContentType() in that order.

If you do a GET request using Android Volley, it should call the methods getHeaders() only.

Reahard

Answer 12

if you use My Singleton try this:

MyVolley.getInstance(this).getRequestQueue().getCache().clear();

Maybe you use cache on your code

Factorial