Viewpager not getting last item

Asked 19/12, 2016 at 6:55 Answered 26/12, 2016 at 18:39

Solved android android-layout arraylist android-viewpager android-pageradapter

I am using two Viewpager in my app,

1) First Viewpager displays images only

2) I am displaying price

now the issue is i have 4 images displaying in my viewpager1, and in second pager i have price as per selected product. first time it does not show anything, but when i scroll image and goes to next, it shows price..

 pager.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
            @Override
            public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {

                Picasso.with(ProductLandingActivity.this)                            .load(categorylist.get(position).getProductLanding_packLink())
                        .error(R.drawable.nopreview )
                        .placeholder(R.drawable.progress_animation)
                        .into(selectedImage);

                System.out.println("Selected is"+position);
              selectedname.setText(categorylist.get(position).getProductLanding_packDesc());

                for (int i = 0; i < categorylist.get(position).getItems().size(); i++) {
                    System.out.println("ProductPack_ID : " + categorylist.get(position).getItems().get(i).getPackSize_sellingPrice());


                }

                temp = categorylist.get(position).getItems();

              packadapter = new MyPacksPagerAdapter(ProductLandingActivity.this,categorylist);
                pagerpacks.setAdapter(packadapter);

            }

            @Override
            public void onPageSelected(int position) {


            }

            @Override
            public void onPageScrollStateChanged(int state) {

            }


        });

adapter

private class MyPacksPagerAdapter extends PagerAdapter {

        Context context;
        ArrayList<PackListModel> packsizedata ;

        public MyPacksPagerAdapter(Context context,ArrayList<PackListModel> packsizedata) {
            this.context = context;
            this.packsizedata = packsizedata;

        }

        @Override
        public Object instantiateItem(ViewGroup container, int position) {

            final OneActor oneActor;

            View view;
            LayoutInflater infl = ((Activity)context).getLayoutInflater();
            view = infl.inflate(R.layout.list_item_pagerpacktitles, container,false);
            oneActor = new OneActor();
           // oneActor.avatar = (ImageView) view.findViewById(R.id.image);
            oneActor.name = (TextView) view.findViewById(R.id.product_landing_packsname);
            oneActor.cmtCount = (TextView) view.findViewById(R.id.product_landing_packsprice);
            view.setTag(oneActor);


          oneActor.name.setText(temp.get(position).getPackSize_packSize());
            oneActor.cmtCount.setText(temp.get(position).getPackSize_sellingPrice());

            ((ViewGroup) container).addView(view);
            return view;
        }

        @Override
        public void destroyItem(ViewGroup container, int position, Object object) {
            container.removeView((View)object);
        }

        @Override
        public int getCount() {
            return packsizedata.size();
        }

        @Override
        public boolean isViewFromObject(View view, Object object) {
            return (view == object);
        }
        class OneActor{
           // ImageView avatar;
            TextView name,cmtCount;
        }
    }

By defaulat when i run the app it shows like this,in second pager it is not showing product price,

But when i scroll image it shows price

My Expected output is

This is my json response

http://pastebin.com/fbJang2B

Retrogression answered 19/12, 2016 at 6:55 Comment(17)

add your logic in onPageSelected. – Kirsch 19/12, 2016 at 6:59

i tried that way.now when i scroll price list it crash invalid index – Retrogression 19/12, 2016 at 7:17

post your crash logcat and code of MyPacksPagerAdapter – Kirsch 19/12, 2016 at 7:20

i added my code in onpage selected..now it start index with 1.. – Retrogression 19/12, 2016 at 8:24

@Kirsch can you tell – Retrogression 20/12, 2016 at 6:37

@Retrogression ..You are not getting proper listview/gridview item click??? Is it your problem?? – Stanzel 21/12, 2016 at 11:40

no its not about click..its about setting second viewpager item as per selected product from first viewpager – Retrogression 21/12, 2016 at 12:12

maybe you are using 1 in currentpage you need to use 0. – Loreleilorelie 26/12, 2016 at 4:9

thanks for comment can you help me with that, what to change – Retrogression 26/12, 2016 at 4:57

it's true.. add your logical code in onPageSelected – Brogue 28/12, 2016 at 6:27

plz..give me your JSON response with image – Brogue 28/12, 2016 at 6:30

@aratikyada pastebin.com/p4kiC9qv – Retrogression 28/12, 2016 at 9:3

@aratikyada any clue mam? – Retrogression 28/12, 2016 at 10:19

Your JSON response is not correct..plz..check again. – Brogue 29/12, 2016 at 5:58

what is the issue – Retrogression 29/12, 2016 at 6:44

you sure you don't have a problem with your xml? – Cathey 29/12, 2016 at 7:19

in my xml what problem you think i have? – Retrogression 29/12, 2016 at 7:26

First, as mentioned by @NotobharatKumar, you're loading the second adapter on a wrong event of the parent adapter, ie in onPageScrolled method. Second, you're setting a new adapter each time on that specific event, it seems useless. Finally, you are setting datas in an event, (I'm not sure why you're doing this but) I'd prefer to set it in a separate adapter and let the events listener for specific behaviors.

For me, it seems that you have two separate adapters, but one datas list shared by both. Assuming that, you have to set them both at start with their datas respectly, and on the event onPageSelected of the top adapter, you just have to automatically scroll the second. And if they have the same position in the list, onPageSelected should do the work correctly.

So, these modifications should solve your issue:

Your code in onScrollChanged, when you set the image and the text, seems really weird to me. I'd use a first adapter where I'll set all the datas like these two for the first ViewPager:

@Override
public void onCreate(Bundle savedInstansteState) {
    ...
    // set a simple adapter for the first ViewPager
    FirstPagerAdapter imageadapter = 
             new FirstPagerAdapter(ProductLandingActivity.this, categorylist);
    pagerimages.setAdapter(imageadapter);
    ...
}

Then, as usual, set your datas in the FirstPagerAdapter:

@Override
public View getView(int position, View view, ViewGroup container) {
    ...
    // set the content
    Picasso.with(ProductLandingActivity.this)                            
        .load(categorylist.get(position).getProductLanding_packLink())
        .error(R.drawable.nopreview )
        .placeholder(R.drawable.progress_animation)
        .into(selectedImage);

    selectedname.setText(
            categorylist.get(position).getProductLanding_packDesc());
    ...
}

Then no need to (re)load the image or the text when an event is triggered, since they will be holding by the adapter.

You only use getPackSize_packSize() and getPackSize_sellingPrice() in the second adapter, so you should create a separate list to only fill with these datas but outside the swiping event. Start by initializing the second list and the adapters:

// get the Items to fill the pack items list (like you did for `temp`)
ArrayList<Items> packItems = new ArrayList<>();
for (int i = 0; i < categorylist.size(); i++) {
    packItems.add(categorylist.get(position).getItems());
}

// fill the first adapter with your list of products (ie categorylist)
...
pagerimages.setAdapter(imageadapter);
...
// fill the second adapter with the pack items list
packadapter = new MyPacksPagerAdapter(ProductLandingActivity.this, packItems);
pagerpacks.setAdapter(packadapter);

You have to do this when categorylist is created and populated. So place this above code for example in your callback, when you retrieve the datas from your server.

Since the second list packItems is filling in the same order than categorylist, there will be no weird behavior by changing the both positions. Now, in the second adapter, it's preferable to use the local list packsizedata, as follows:

@Override
public Object instantiateItem(ViewGroup container, int position) {
    ...
    oneActor.name.setText(
            packsizedata.get(position).getPackSize_packSize());
    oneActor.cmtCount.setText(
            packsizedata.get(position).getPackSize_sellingPrice());
    ...
}

Finally, control the bottom ViewPager by using onPageSelected event of the first:

pager.addOnPageChangeListener(new ViewPager.OnPageChangeListener() {
    @Override
    public void onPageScrolled(int position, float positionOffset, 
                            int positionOffsetPixels) { }

    @Override
    public void onPageSelected(int position) {
        // set the second current page regarding the position of the first
        pagerpacks.setCurrentItem(position);
    }

    @Override
    public void onPageScrollStateChanged(int state) { }
});

Hope this will be helpful.

Accumulate answered 26/12, 2016 at 18:39 Comment(8)

@Retrogression To me, PackSizeModel should be a class with only two variables packSize and sellingPrice, so you only need to found and add to the list only this Class filled in with these two datas. You're actually returning an arraylist of PackSizeModel, whereas you only want the datas. – Accumulate 29/12, 2016 at 14:45

what to change in code? and how can i get solution – Retrogression 30/12, 2016 at 3:36

bro need your help can you tell what to change? – Retrogression 30/12, 2016 at 9:31

@Retrogression PackSizeModel should be something like this and getItems() should return PackSizeModel and not an array. Make some changes in getItems() to return the populated model and not an arraylist of this model. – Accumulate 30/12, 2016 at 19:41

can you help please? – Retrogression 3/1, 2017 at 4:10

give mail id i send demo so that easily you will understand the issue – Retrogression 3/1, 2017 at 4:11

@Retrogression I understood your issue as I saw your screenshot. But as I said three times now, you need to populate the model in getItems method and return this new model. I got nothing else to say. You need to make some basic researches, this is a minor issue that you should understand. I don't get what you don't understand with my comments... However, I'll try to help you another step, send me the getItems method in pastebin (or the full object class where getItems is in to). – Accumulate 3/1, 2017 at 17:10

i need help https://mcmap.net/q/57923/-how-to-store-call-records-in-sd-card – Retrogression 7/3, 2017 at 4:7

You should implement code for action at onPageSelected method because after page changed of your ViewPager then onPageSelected will be called.

Medievalist answered 19/12, 2016 at 7:26 Comment(6)

position always start with 0. there must be something bug. can you share your code. – Medievalist 19/12, 2016 at 8:52

can you check now? – Retrogression 19/12, 2016 at 9:4

You have used two pager in your code. which one having issue? – Medievalist 19/12, 2016 at 9:24

when i scroll first view pager,second is not setting properly – Retrogression 19/12, 2016 at 9:28

I think you using wrong array at your adapter in method onPageSelected() please check. packadapter = new MyPacksPagerAdapter(ProductLandingActivity.this,categorylist); – Medievalist 19/12, 2016 at 9:44

I guess there you have passed same array "categorylist‌" that you used in parent viewpage. – Medievalist 19/12, 2016 at 9:56

Hot tags

Godot Unity Godot Help Programming Godot 4.X GUI GDScript 3D 2D Physics CSharp Godot 3.X VR XR Projects C++

Recommended topics

Hot tags