MVC3 Decimal truncated to 2 decimal places on edit
Asked Answered
S

3

29

I'm running MVC3 with Razor and noticed that decimal values are truncated to 2 decimal places when in edit mode. I've managed to get round it by annotating my property with a display format. This doesn't seem like a very good solution as I'll have to remember to do this for every new view I generate (or update my templates).

I have checked the value returned by our service to the controller and it is correct at 1.144, but when bound to the view it comes out as 1.14 in the TextBox

ViewModel Property

[Required]
[Display(Name = "Unit Price")]
public decimal UnitPrice { get; set; }

.cshtml Code

@Html.LabelFor(model => model.UnitPrice) 
@Html.EditorFor(model => model.UnitPrice) 
@Html.ValidationMessageFor(model => model.UnitPrice)

If I decorate the property with the following then it works.

[DisplayFormat(
               ApplyFormatInEditMode = true, 
               DataFormatString = "{0:0.00###########################}", 
               NullDisplayText = "")]

Any Ideas?

Shouse answered 25/3, 2011 at 3:38 Comment(2)
Since decimal is often used in financial related scenarios, possibly MVC is trying to be too smart for its own good here.Proverbs
It's not MVC doing this. Do you have a decimal template somewhere with it's own truncation?Stob
C
33

That's how the default Decimal editor template is defined:

<%@ Control Language="C#" Inherits="System.Web.Mvc.ViewUserControl" %>
<script runat="server">
    private object ModelValue {
        get {
            if (ViewData.TemplateInfo.FormattedModelValue == ViewData.ModelMetadata.Model) {
                return String.Format(
                    System.Globalization.CultureInfo.CurrentCulture,
                    "{0:0.00}", ViewData.ModelMetadata.Model
                );
            }
            return ViewData.TemplateInfo.FormattedModelValue;
        }
    }
</script>
<%= Html.TextBox("", ModelValue, new { @class = "text-box single-line" }) %>

Notice the {0:0.00} format.

So you have two possibilities:

  1. Use double instead of decimal as type in your model
  2. Modify the default editor template by creating a custom ~/Views/Shared/EditorTemplates/Decimal.cshtml which might simply look like this:

    @Html.TextBox(
        "", 
        ViewData.TemplateInfo.FormattedModelValue, 
        new { @class = "text-box single-line" }
    )
    

You probably might want to modify the display template as well.

Chile answered 25/3, 2011 at 7:10 Comment(0)
B
11

IMO, this article has a better option:

html-editorfor-with-3-decimal-places

I used this code to display up to 4 decimal digits in my EditFor:

    [Display(Name = "Discount Percentage")]
    [Range(0, 100.0)]
    [DisplayFormat(DataFormatString="{0:0.0000}", ApplyFormatInEditMode=true)]
    public Decimal? DiscountPercent { get; set; }
Beak answered 11/8, 2016 at 12:26 Comment(2)
this is best solution presentedSassoon
Nice, that works well and is better than creating a custom editortemplate in my opinion. If you want the decimal points to only show if the decimal has decimal points, replace the 0s with #s: [DisplayFormat(DataFormatString = "{0:0.####}", ApplyFormatInEditMode = true)]Molding
M
9

If you don't need the functionality of the 'EditorFor' HtmlHelper, you can simply swap it out for the 'TextBoxFor' and it shouldn't truncate your decimal value...

Maihem answered 9/1, 2012 at 6:22 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.