How to get the line count of a large file cheaply in Python
Asked Answered
O

44

1298

How do I get a line count of a large file in the most memory- and time-efficient manner?

def file_len(filename):
    with open(filename) as f:
        for i, _ in enumerate(f):
            pass
    return i + 1
Outset answered 10/5, 2009 at 10:22 Comment(11)
Do you need exact line count or will an approximation suffice?Roughish
I would add i=-1 before for loop, since this code doesn't work for empty files.Ohl
@Legend: I bet pico is thinking, get the file size (with seek(0,2) or equiv), divide by approximate line length. You could read a few lines at the beginning to guess the average line length.Supervisor
enumerate(f, 1) and ditch the i + 1?Unwise
@IanMackinnon Works for empty files, but you have to initialize i to 0 before the for-loop.Unlatch
related: Why is reading lines from stdin much slower in C++ than Python?. See comparison with wc-l.py thereKilovolt
I originally came to this post trying to find a fast way of pre-allocating a table stored as text. However, in my case, I found that it is faster to append values to a list (allowing the list to grow dynamically) rather than read the file twice. Depending on your I/O speed, this may be something to think about.Enrapture
There is a better way, doesn't change much. Add the "r" flag to the open function so it doesn't have to automatically figure out what flag to use. I timed it, that method is ~0.01 seconds slower without the "r" flag.Atp
This code returns 1 for empty files as well as files that have 1 line without a newline.Moran
My one line solution was total_row_count = len(open(single_file).read().splitlines()). Testing the speed of both against a 1GB csv file yours takes 1.7seconds and mine takes 7.3Halfblooded
@Halfblooded reading and splitting lines is not ideal because you have to not only have the whole file in memory but also process it to extract the lines and store in a list before getting the length. For a one liner, the answer from Kyle is the best num_lines = sum(1 for _ in open('myfile.txt')) ... but it is still relatively slow compared to some other solutions (with buffers or mmap for example). See https://mcmap.net/q/45407/-how-to-get-the-line-count-of-a-large-file-cheaply-in-pythonInfinite
P
430

You can't get any better than that.

After all, any solution will have to read the entire file, figure out how many \n you have, and return that result.

Do you have a better way of doing that without reading the entire file? Not sure... The best solution will always be I/O-bound, best you can do is make sure you don't use unnecessary memory, but it looks like you have that covered.

[Edit May 2023]

As commented in many other answers, in Python 3 there are better alternatives. The for loop is not the most efficient. For example, using mmap or buffers is more efficient.

Panaggio answered 10/5, 2009 at 10:37 Comment(14)
Exactly, even WC is reading through the file, but in C and it's probably pretty optimized.Pointenoire
As far as I understand the Python file IO is done through C as well. docs.python.org/library/stdtypes.html#file-objectsDowns
posix_fadvise() might be used #861393 Though I've not noticed any improvement gist.github.com/0ac760859e614cd03652Kilovolt
@Downs That's a red herring. While python and wc might be issuing the same syscalls, python has opcode dispatch overhead that wc doesn't have.Commonality
You can approximate a line count by sampling. It can be thousands of times faster. See: documentroot.com/2011/02/…Alyciaalyda
Other answers seem to indicate this categorical answer is wrong, and should therefore be deleted rather than kept as accepted.Alkalinity
wouldn't generators or list comprehension methods with the sum() method be faster?Parodist
This answer is plain wrong. Please see glglgl's answer here: https://mcmap.net/q/46483/-python-counting-lines-in-a-huge-gt-10gb-file-as-fast-as-possible-duplicateDumfries
Simply untrue. Finding lines means finding newlines. You can parallelise reading chunks of the file, and searching for newlines, for example by having multiple processes search regions of a memory mapped file.Mellott
@DaveLiu want to explain why?Atelectasis
@Hyperbole, the multiple different highly-upvoted answers. If you have uniform-sized data, it could be a simple matter of mathematical calculation. If you have distributed computing capabilities, you could do as martlark has done. Saying "You can't get any better than that" fails to take into consideration multiple conditions and is a sweeping generalization. Stackoverflow is about finding solutions to specific problems, not just "Well, that seems like about it." Yes, any solution is I/O bound, but as others have demonstrated, you can get closer to that bound than OP's code.Milline
@DaveLiu Okay. I was asking because your comment predates the two runner-up answers, so I thought maybe you had seen something they didn't.Atelectasis
Funny that wc is mentioned as a great deal for this when it is known to perform very poorly for counting lines of a big file compared to awk or grep...Penzance
Another problem with "iterating by lines" approach is reading whole lines into memory. A huge line might eat up a lot of RAM for literally no reason.Thomsen
H
808

One line, faster than the for loop of the OP (although not the fastest) and very concise:

num_lines = sum(1 for _ in open('myfile.txt'))

You can also boost the speed (and robustness) by using rbU mode and include it in a with block to close the file:

with open("myfile.txt", "rbU") as f:
    num_lines = sum(1 for _ in f)

Note: The U in rbU mode is deprecated since Python 3.3 and above, so iwe should use rb instead of rbU (and it has been removed in Python 3.11).

Hourglass answered 19/6, 2009 at 19:7 Comment(7)
its similar to sum(sequence of 1) every line is counting as 1. >>> [ 1 for line in range(10) ] [1, 1, 1, 1, 1, 1, 1, 1, 1, 1] >>> sum( 1 for line in range(10) ) 10 >>>Shari
num_lines = sum(1 for line in open('myfile.txt') if line.rstrip()) for filter empty linesPenstock
as we open a file, will this be closed automatically once we iterate over all the elements? Is it required to 'close()'? I think we cannot use 'with open()' in this short statement, right?Balky
A slight lint improvement: num_lines = sum(1 for _ in open('myfile.txt'))Judas
It's not any faster than the other solutions, see https://mcmap.net/q/45407/-how-to-get-the-line-count-of-a-large-file-cheaply-in-python.Decumbent
@Balky we could also enclose it in a with open(...) as f block and loop over f.Infinite
'U' mode enabled universal newlines but was removed in Python 3.11 as it became the default behaviour in Python 3.0. Source: docs.python.org/3.10/library/functions.html#openChlo
P
430

You can't get any better than that.

After all, any solution will have to read the entire file, figure out how many \n you have, and return that result.

Do you have a better way of doing that without reading the entire file? Not sure... The best solution will always be I/O-bound, best you can do is make sure you don't use unnecessary memory, but it looks like you have that covered.

[Edit May 2023]

As commented in many other answers, in Python 3 there are better alternatives. The for loop is not the most efficient. For example, using mmap or buffers is more efficient.

Panaggio answered 10/5, 2009 at 10:37 Comment(14)
Exactly, even WC is reading through the file, but in C and it's probably pretty optimized.Pointenoire
As far as I understand the Python file IO is done through C as well. docs.python.org/library/stdtypes.html#file-objectsDowns
posix_fadvise() might be used #861393 Though I've not noticed any improvement gist.github.com/0ac760859e614cd03652Kilovolt
@Downs That's a red herring. While python and wc might be issuing the same syscalls, python has opcode dispatch overhead that wc doesn't have.Commonality
You can approximate a line count by sampling. It can be thousands of times faster. See: documentroot.com/2011/02/…Alyciaalyda
Other answers seem to indicate this categorical answer is wrong, and should therefore be deleted rather than kept as accepted.Alkalinity
wouldn't generators or list comprehension methods with the sum() method be faster?Parodist
This answer is plain wrong. Please see glglgl's answer here: https://mcmap.net/q/46483/-python-counting-lines-in-a-huge-gt-10gb-file-as-fast-as-possible-duplicateDumfries
Simply untrue. Finding lines means finding newlines. You can parallelise reading chunks of the file, and searching for newlines, for example by having multiple processes search regions of a memory mapped file.Mellott
@DaveLiu want to explain why?Atelectasis
@Hyperbole, the multiple different highly-upvoted answers. If you have uniform-sized data, it could be a simple matter of mathematical calculation. If you have distributed computing capabilities, you could do as martlark has done. Saying "You can't get any better than that" fails to take into consideration multiple conditions and is a sweeping generalization. Stackoverflow is about finding solutions to specific problems, not just "Well, that seems like about it." Yes, any solution is I/O bound, but as others have demonstrated, you can get closer to that bound than OP's code.Milline
@DaveLiu Okay. I was asking because your comment predates the two runner-up answers, so I thought maybe you had seen something they didn't.Atelectasis
Funny that wc is mentioned as a great deal for this when it is known to perform very poorly for counting lines of a big file compared to awk or grep...Penzance
Another problem with "iterating by lines" approach is reading whole lines into memory. A huge line might eat up a lot of RAM for literally no reason.Thomsen
R
230

I believe that a memory mapped file will be the fastest solution. I tried four functions: the function posted by the OP (opcount); a simple iteration over the lines in the file (simplecount); readline with a memory-mapped filed (mmap) (mapcount); and the buffer read solution offered by Mykola Kharechko (bufcount).

I ran each function five times, and calculated the average run-time for a 1.2 million-line text file.

Windows XP, Python 2.5, 2 GB RAM, 2 GHz AMD processor

Here are my results:

mapcount : 0.465599966049
simplecount : 0.756399965286
bufcount : 0.546800041199
opcount : 0.718600034714

Numbers for Python 2.6:

mapcount : 0.471799945831
simplecount : 0.634400033951
bufcount : 0.468800067902
opcount : 0.602999973297

So the buffer read strategy seems to be the fastest for Windows/Python 2.6

Here is the code:

from __future__ import with_statement
import time
import mmap
import random
from collections import defaultdict

def mapcount(filename):
    with open(filename, "r+") as f:
        buf = mmap.mmap(f.fileno(), 0)
        lines = 0
        readline = buf.readline
        while readline():
            lines += 1
        return lines

def simplecount(filename):
    lines = 0
    for line in open(filename):
        lines += 1
    return lines

def bufcount(filename):
    f = open(filename)
    lines = 0
    buf_size = 1024 * 1024
    read_f = f.read # loop optimization

    buf = read_f(buf_size)
    while buf:
        lines += buf.count('\n')
        buf = read_f(buf_size)

    return lines

def opcount(fname):
    with open(fname) as f:
        for i, l in enumerate(f):
            pass
    return i + 1


counts = defaultdict(list)

for i in range(5):
    for func in [mapcount, simplecount, bufcount, opcount]:
        start_time = time.time()
        assert func("big_file.txt") == 1209138
        counts[func].append(time.time() - start_time)

for key, vals in counts.items():
    print key.__name__, ":", sum(vals) / float(len(vals))
Recollect answered 12/5, 2009 at 2:49 Comment(3)
It seems that wccount() is the fastest gist.github.com/0ac760859e614cd03652Kilovolt
The buffered read is the fastest solution, not mmap or wccount. See https://mcmap.net/q/45407/-how-to-get-the-line-count-of-a-large-file-cheaply-in-python.Decumbent
@NicoSchlömer it depends the characteristics of your file. See https://mcmap.net/q/45407/-how-to-get-the-line-count-of-a-large-file-cheaply-in-python for a comparison of both on different files.Infinite
J
219

All of these solutions ignore one way to make this run considerably faster, namely by using the unbuffered (raw) interface, using bytearrays, and doing your own buffering. (This only applies in Python 3. In Python 2, the raw interface may or may not be used by default, but in Python 3, you'll default into Unicode.)

Using a modified version of the timing tool, I believe the following code is faster (and marginally more Pythonic) than any of the solutions offered:

def rawcount(filename):
    f = open(filename, 'rb')
    lines = 0
    buf_size = 1024 * 1024
    read_f = f.raw.read

    buf = read_f(buf_size)
    while buf:
        lines += buf.count(b'\n')
        buf = read_f(buf_size)

    return lines

Using a separate generator function, this runs a smidge faster:

def _make_gen(reader):
    b = reader(1024 * 1024)
    while b:
        yield b
        b = reader(1024*1024)

def rawgencount(filename):
    f = open(filename, 'rb')
    f_gen = _make_gen(f.raw.read)
    return sum(buf.count(b'\n') for buf in f_gen)

This can be done completely with generators expressions in-line using itertools, but it gets pretty weird looking:

from itertools import (takewhile, repeat)

def rawincount(filename):
    f = open(filename, 'rb')
    bufgen = takewhile(lambda x: x, (f.raw.read(1024*1024) for _ in repeat(None)))
    return sum(buf.count(b'\n') for buf in bufgen)

Here are my timings:

function      average, s  min, s   ratio
rawincount        0.0043  0.0041   1.00
rawgencount       0.0044  0.0042   1.01
rawcount          0.0048  0.0045   1.09
bufcount          0.008   0.0068   1.64
wccount           0.01    0.0097   2.35
itercount         0.014   0.014    3.41
opcount           0.02    0.02     4.83
kylecount         0.021   0.021    5.05
simplecount       0.022   0.022    5.25
mapcount          0.037   0.031    7.46
Jellicoe answered 17/12, 2014 at 4:32 Comment(14)
I am working with 100Gb+ files, and your rawgencounts is the only feasible solution I have seen so far. Thanks!Pretentious
is wccount in this table for the subprocess shell wc tool?Larrikin
found this in another comment, I guess it is then gist.github.com/zed/0ac760859e614cd03652Larrikin
Would changing the return statement in the first example to return sum(map(methodcaller("count", b'\n'), f_gen)), importing methodcaller from operator help speed this up any (imap from itertools as well if python2)? I would also constify the 1024*1024 math in _make_gen to save a few extra cycles. Would like to see the comparison with the pure-generator example as well.Construe
Thanks @michael-bacon, it's a really nice solution. You can make the rawincount solution less weird looking by using bufgen = iter(partial(f.raw.read, 1024*1024), b'') instead of combining takewhile and repeat.Ample
Oh, partial function, yeah, that's a nice little tweak. Also, I assumed that the 1024*1024 would get merged by the interpreter and treated as a constant but that was on hunch not documentation.Jellicoe
@MichaelBacon, would it be faster to open the file with buffering=0 and then calling read instead of just opening the file as "rb" and calling raw.read, or will that be optimized to the same thing?Paraphrast
@Paraphrast this is a late reply but I am not enough of a python core junkie to know that for sure. All I can say is, run the speed tests and see!Jellicoe
If the file is opened via gzip.open you get AttributeError: 'GzipFile' object has no attribute 'raw'. I think read_f line should be replaced with read_f = f.raw.read if hasattr(f, 'raw') and hasattr(f.raw, 'read') else f.readParadies
Also for plain (not compressed) files you may want to use mmapParadies
This is really fast. Still one should probably close the file handler before leaving the function, right?Stelle
@Paraphrast checked this - looks like the same time on my dataHeterochromous
Good solution. I've also checked @Avraham's suggestion and got - on average - a slight improvement (it's also a bit closer to the standard api use - whatever that means :)).Latif
Probably 100 GB, not 100 Gb.Innermost
R
106

You could execute a subprocess and run wc -l filename

import subprocess

def file_len(fname):
    p = subprocess.Popen(['wc', '-l', fname], stdout=subprocess.PIPE, 
                                              stderr=subprocess.PIPE)
    result, err = p.communicate()
    if p.returncode != 0:
        raise IOError(err)
    return int(result.strip().split()[0])
Rosner answered 10/5, 2009 at 10:28 Comment(7)
what would be the windows version of this?Outset
You can refer to this SO question regarding that. #247734Pointenoire
Indeed, in my case (Mac OS X) this takes 0.13s versus 0.5s for counting the number of lines "for x in file(...)" produces, versus 1.0s counting repeated calls to str.find or mmap.find. (The file I used to test this has 1.3 million lines.)Gleich
No need to involve the shell on that. edited answer and added example code;Tingey
On command line (without the overhead of creating another shell) this is the same fast as the more clear and portable python-only solution. See also: #849558Taw
Is not cross platform.Hutson
And by "cross-platform" you mean it doesn't work on Windows.Waltz
D
69

After a perfplot analysis, one has to recommend the buffered read solution

def buf_count_newlines_gen(fname):
    def _make_gen(reader):
        while True:
            b = reader(2 ** 16)
            if not b: break
            yield b

    with open(fname, "rb") as f:
        count = sum(buf.count(b"\n") for buf in _make_gen(f.raw.read))
    return count

It's fast and memory-efficient. Most other solutions are about 20 times slower.

enter image description here


Code to reproduce the plot:

import mmap
import subprocess
from functools import partial

import perfplot


def setup(n):
    fname = "t.txt"
    with open(fname, "w") as f:
        for i in range(n):
            f.write(str(i) + "\n")
    return fname


def for_enumerate(fname):
    i = 0
    with open(fname) as f:
        for i, _ in enumerate(f):
            pass
    return i + 1


def sum1(fname):
    return sum(1 for _ in open(fname))


def mmap_count(fname):
    with open(fname, "r+") as f:
        buf = mmap.mmap(f.fileno(), 0)

    lines = 0
    while buf.readline():
        lines += 1
    return lines


def for_open(fname):
    lines = 0
    for _ in open(fname):
        lines += 1
    return lines


def buf_count_newlines(fname):
    lines = 0
    buf_size = 2 ** 16
    with open(fname) as f:
        buf = f.read(buf_size)
        while buf:
            lines += buf.count("\n")
            buf = f.read(buf_size)
    return lines


def buf_count_newlines_gen(fname):
    def _make_gen(reader):
        b = reader(2 ** 16)
        while b:
            yield b
            b = reader(2 ** 16)

    with open(fname, "rb") as f:
        count = sum(buf.count(b"\n") for buf in _make_gen(f.raw.read))
    return count


def wc_l(fname):
    return int(subprocess.check_output(["wc", "-l", fname]).split()[0])


def sum_partial(fname):
    with open(fname) as f:
        count = sum(x.count("\n") for x in iter(partial(f.read, 2 ** 16), ""))
    return count


def read_count(fname):
    return open(fname).read().count("\n")


b = perfplot.bench(
    setup=setup,
    kernels=[
        for_enumerate,
        sum1,
        mmap_count,
        for_open,
        wc_l,
        buf_count_newlines,
        buf_count_newlines_gen,
        sum_partial,
        read_count,
    ],
    n_range=[2 ** k for k in range(27)],
    xlabel="num lines",
)
b.save("out.png")
b.show()
Dotted answered 14/7, 2021 at 22:19 Comment(2)
I hae very long lines in my file; i'm thinking the buffer should be allocated only once using readintoBeverly
Great graph: thanks for the code. But actually, this overlooks the case where a line is more than just than 10 characters. For long lines, mmap tends to be more efficient than buf_count_newlines_gen: see answer https://mcmap.net/q/45407/-how-to-get-the-line-count-of-a-large-file-cheaply-in-pythonInfinite
T
50

A one-line Bash solution similar to this answer, using the modern subprocess.check_output function:

def line_count(filename):
    return int(subprocess.check_output(['wc', '-l', filename]).split()[0])
Twigg answered 3/4, 2017 at 7:48 Comment(2)
This answer should be voted up to a higher spot in this thread for Linux/Unix users. Despite the majority preferences in a cross-platform solution, this is a superb way on Linux/Unix. For a 184-million-line csv file I have to sample data from, it provides the best runtime. Other pure python solutions take on average 100+ seconds whereas subprocess call of wc -l takes ~ 5 seconds.Foudroyant
shell=True is bad for security, it is better to avoid it.Edmea
C
49

Here is a Python program to use the multiprocessing library to distribute the line counting across machines/cores. My test improves counting a 20 million line file from 26 seconds to 7 seconds using an 8-core Windows 64-bit server. Note: not using memory mapping makes things much slower.

import multiprocessing, sys, time, os, mmap
import logging, logging.handlers

def init_logger(pid):
    console_format = 'P{0} %(levelname)s %(message)s'.format(pid)
    logger = logging.getLogger()  # New logger at root level
    logger.setLevel(logging.INFO)
    logger.handlers.append(logging.StreamHandler())
    logger.handlers[0].setFormatter(logging.Formatter(console_format, '%d/%m/%y %H:%M:%S'))

def getFileLineCount(queues, pid, processes, file1):
    init_logger(pid)
    logging.info('start')

    physical_file = open(file1, "r")
    #  mmap.mmap(fileno, length[, tagname[, access[, offset]]]

    m1 = mmap.mmap(physical_file.fileno(), 0, access=mmap.ACCESS_READ)

    # Work out file size to divide up line counting

    fSize = os.stat(file1).st_size
    chunk = (fSize / processes) + 1

    lines = 0

    # Get where I start and stop
    _seedStart = chunk * (pid)
    _seekEnd = chunk * (pid+1)
    seekStart = int(_seedStart)
    seekEnd = int(_seekEnd)

    if seekEnd < int(_seekEnd + 1):
        seekEnd += 1

    if _seedStart < int(seekStart + 1):
        seekStart += 1

    if seekEnd > fSize:
        seekEnd = fSize

    # Find where to start
    if pid > 0:
        m1.seek(seekStart)
        # Read next line
        l1 = m1.readline()  # Need to use readline with memory mapped files
        seekStart = m1.tell()

    # Tell previous rank my seek start to make their seek end

    if pid > 0:
        queues[pid-1].put(seekStart)
    if pid < processes-1:
        seekEnd = queues[pid].get()

    m1.seek(seekStart)
    l1 = m1.readline()

    while len(l1) > 0:
        lines += 1
        l1 = m1.readline()
        if m1.tell() > seekEnd or len(l1) == 0:
            break

    logging.info('done')
    # Add up the results
    if pid == 0:
        for p in range(1, processes):
            lines += queues[0].get()
        queues[0].put(lines) # The total lines counted
    else:
        queues[0].put(lines)

    m1.close()
    physical_file.close()

if __name__ == '__main__':
    init_logger('main')
    if len(sys.argv) > 1:
        file_name = sys.argv[1]
    else:
        logging.fatal('parameters required: file-name [processes]')
        exit()

    t = time.time()
    processes = multiprocessing.cpu_count()
    if len(sys.argv) > 2:
        processes = int(sys.argv[2])
    queues = [] # A queue for each process
    for pid in range(processes):
        queues.append(multiprocessing.Queue())
    jobs = []
    prev_pipe = 0
    for pid in range(processes):
        p = multiprocessing.Process(target = getFileLineCount, args=(queues, pid, processes, file_name,))
        p.start()
        jobs.append(p)

    jobs[0].join() # Wait for counting to finish
    lines = queues[0].get()

    logging.info('finished {} Lines:{}'.format( time.time() - t, lines))
Chaldea answered 26/7, 2011 at 6:51 Comment(7)
How does this work with files much bigger than main memory? for instance a 20GB file on a system with 4GB RAM and 2 coresAnopheles
Hard to test now, but I presume it would page the file in and out.Chaldea
This is pretty neat code. I was surprised to find that it is faster to use multiple processors. I figured that the IO would be the bottleneck. In older Python versions, line 21 needs int() like chunk = int((fSize / processes)) + 1Ope
do it load all the file into the memory? what about a bigger fire where the size is bigger then the ram on the computer?Gomer
The files are mapped into virtual memory, so the size of the file and the amount of actual memory is usually not a restriction.Chaldea
Would you mind if I formatted the answer with black? black.vercel.appNucleonics
It does need itChaldea
H
18

I would use Python's file object method readlines, as follows:

with open(input_file) as foo:
    lines = len(foo.readlines())

This opens the file, creates a list of lines in the file, counts the length of the list, saves that to a variable and closes the file again.

Hydrophilous answered 8/10, 2013 at 12:46 Comment(4)
While this is one of the first ways that comes to mind, it probably isn't very memory efficient, especially if counting lines in files up to 10 GB (Like I do), which is a noteworthy disadvantage.Equivalency
@TimeSheep Is this an issue for files with many (say, billions) of small lines, or files which have extremely long lines (say, Gigabytes per line)?Propeller
The reason I ask is, it would seem that the compiler should be able to optimize this away by not creating an intermediate list.Propeller
@dmityugov Per Python docs, xreadlines has been deprecated since 2.3, as it just returns an iterator. for line in file is the stated replacement. See: docs.python.org/2/library/stdtypes.html#file.xreadlinesConstrue
D
14

This is the fastest thing I have found using pure Python.

You can use whatever amount of memory you want by setting buffer, though 2**16 appears to be a sweet spot on my computer.

from functools import partial

buffer=2**16
with open(myfile) as f:
        print sum(x.count('\n') for x in iter(partial(f.read,buffer), ''))

I found the answer here Why is reading lines from stdin much slower in C++ than Python? and tweaked it just a tiny bit. It’s a very good read to understand how to count lines quickly, though wc -l is still about 75% faster than anything else.

Disjuncture answered 9/12, 2016 at 20:34 Comment(0)
R
13
def file_len(full_path):
  """ Count number of lines in a file."""
  f = open(full_path)
  nr_of_lines = sum(1 for line in f)
  f.close()
  return nr_of_lines
Roping answered 10/5, 2009 at 10:33 Comment(2)
The command "sum(1 for line in f)" seems to delete the content of the file. The command "f.readline()" returns null if I put it after that line.Gratifying
@EnteFetz that's because the file handle is exhausted, so there are no more lines to read. If you do f.seek(0); f.readline() this problem won't persistFrady
P
12

Here is what I use, and it seems pretty clean:

import subprocess

def count_file_lines(file_path):
    """
    Counts the number of lines in a file using wc utility.
    :param file_path: path to file
    :return: int, no of lines
    """
    num = subprocess.check_output(['wc', '-l', file_path])
    num = num.split(' ')
    return int(num[0])

This is marginally faster than using pure Python, but at the cost of memory usage. Subprocess will fork a new process with the same memory footprint as the parent process while it executes your command.

Polestar answered 26/7, 2017 at 18:13 Comment(5)
Just as a side note, this won't work on Windows of course.Muster
core utils apparently provides "wc" for windows #247734. You can also use a linux VM in your windows box if your code will end up running in linux in prod.Polestar
Or WSL, highly advised over any VM if stuff like this is the only thing you do. :-)Muster
Yeah that works. I'm not a windows guy but from goolging I learned WSL = Windows Subsystem for Linux =)Polestar
python3.7: subprocess return bytes, so code looks like this: int(subprocess.check_output(['wc', '-l', file_path]).decode("utf-8").lstrip().split(" ")[0])Fosterfosterage
F
10

One line solution:

import os
os.system("wc -l  filename")  

My snippet:

>>> os.system('wc -l *.txt')

Output:

0 bar.txt
1000 command.txt
3 test_file.txt
1003 total
Franckot answered 6/1, 2017 at 8:29 Comment(8)
Good idea, unfortunately this does not work on Windows though.Eggcup
if you want to be surfer of python , say good bye to windows.Believe me you will thank me one day .Franckot
I just considered it noteworthy that this will only work on windows. I prefer working on a linux/unix stack myself, but when writing software IMHO one should consider the side effects a program could have when run under different OSes. As the OP did not mention his platform and in case anyone pops on this solution via google and copies it (unaware of the limitations a Windows system might have), I wanted to add the note.Eggcup
You can't save output of os.system() to variable and post-process it anyhow.Frozen
@AnSe you are correct but question is not asked whether it saves or not.I guess you are understanding the context.Franckot
@TheExorcist, nope, in question author actually uses a func that returns a value.Frozen
@AnSe yes sir you are right, but question asked was What is the most efficient way both memory- and time-wise? later OP ask to suggest some other ways, in answer OP used a return value function as an instance.But may be your are right, I will throw this question to meta-tags, for further analysis.Franckot
If you want ONLY the count change to it os.system("wc -l < filename")Atomic
V
9

Kyle's answer

num_lines = sum(1 for line in open('my_file.txt'))

is probably best. An alternative for this is:

num_lines =  len(open('my_file.txt').read().splitlines())

Here is the comparison of performance of both:

In [20]: timeit sum(1 for line in open('Charts.ipynb'))
100000 loops, best of 3: 9.79 µs per loop

In [21]: timeit len(open('Charts.ipynb').read().splitlines())
100000 loops, best of 3: 12 µs per loop
Voidable answered 15/10, 2014 at 5:22 Comment(0)
G
7

I got a small (4-8%) improvement with this version which reuses a constant buffer, so it should avoid any memory or GC overhead:

lines = 0
buffer = bytearray(2048)
with open(filename) as f:
  while f.readinto(buffer) > 0:
      lines += buffer.count('\n')

You can play around with the buffer size and maybe see a little improvement.

Goatfish answered 25/2, 2013 at 19:31 Comment(4)
Nice. To account for files that don't end in \n, add 1 outside of loop if buffer and buffer[-1]!='\n'Dispenser
A bug: buffer in the last round might not be clean.Curcuma
what if in between buffers one portion ends with \ and the other portion starts with n? that will miss one new line in there, I would sudgest to variables to store the end and the start of each chunk, but that might add more time to the script =(Gomer
What file size? And other context, like the underlying hardware (disk type and speed. RAM, incl. speed. L1, L2, and L3 cache sizes. Etc.)Innermost
P
5

As for me this variant will be the fastest:

#!/usr/bin/env python

def main():
    f = open('filename')                  
    lines = 0
    buf_size = 1024 * 1024
    read_f = f.read # loop optimization

    buf = read_f(buf_size)
    while buf:
        lines += buf.count('\n')
        buf = read_f(buf_size)

    print lines

if __name__ == '__main__':
    main()

reasons: buffering faster than reading line by line and string.count is also very fast

Petey answered 10/5, 2009 at 11:29 Comment(6)
But is it? At least on OSX/python2.5 the OP's version is still about 10% faster according to timeit.py.Tomchay
What if the last line does not end in '\n'?Mccowyn
I don't know how you tested it, dF, but on my machine it's ~2.5 times slower than any other option.Outset
You state that it will be the fastest and then state that you haven't tested it. Not very scientific eh? :)Pointenoire
See solution and stats provided by Ryan Ginstrom answer below. Also check out JF Sebastian's comment and link on the same answer.Mirza
It shows: mapcount() and wccount() are both faster than buffcount, though buffcount does seem to beat opcount and simplecount.Mirza
V
5

Just to complete the methods in previous answers, I tried a variant with the fileinput module:

import fileinput as fi   

def filecount(fname):
        for line in fi.input(fname):
            pass
        return fi.lineno()

And passed a 60-million-lines file to all the stated methods in previous answers:

mapcount:    6.13
simplecount: 4.59
opcount:     4.43
filecount:  43.3
bufcount:    0.171

It's a little surprise to me that fileinput is that bad and scales far worse than all the other methods...

Varro answered 5/5, 2010 at 11:48 Comment(0)
C
5

This code is shorter and clearer. It's probably the best way:

num_lines = open('yourfile.ext').read().count('\n')
Campaign answered 23/2, 2015 at 18:38 Comment(2)
You should also close the file.Floris
It will load the whole file into memory.Footie
M
4

I have modified the buffer case like this:

def CountLines(filename):
    f = open(filename)
    try:
        lines = 1
        buf_size = 1024 * 1024
        read_f = f.read # loop optimization
        buf = read_f(buf_size)

        # Empty file
        if not buf:
            return 0

        while buf:
            lines += buf.count('\n')
            buf = read_f(buf_size)

        return lines
    finally:
        f.close()

Now also empty files and the last line (without \n) are counted.

Madore answered 25/11, 2011 at 14:55 Comment(2)
Maybe also explain (or add in comment in the code) what you changed and what for ;). Might give people some more inside in your code much easier (rather than "parsing" the code in the brain).Almsman
The loop optimization I think allows Python to do a local variable lookup at read_f, python.org/doc/essays/list2strSantanasantayana
I
4

There are already so many answers with great timing comparison, but I believe they are just looking at number of lines to measure performance (e.g., the great graph from Nico Schlömer).

To be accurate while measuring performance, we should look at:

  • the number of lines
  • the average size of the lines
  • ... the resulting total size of the file (which might impact memory)

First of all, the function of the OP (with a for) and the function sum(1 for line in f) are not performing that well...

Good contenders are with mmap or buffer.

To summarize: based on my analysis (Python 3.9 on Windows with SSD):

  1. For big files with relatively short lines (within 100 characters): use function with a buffer buf_count_newlines_gen

    def buf_count_newlines_gen(fname: str) -> int:
        """Count the number of lines in a file"""
        def _make_gen(reader):
            b = reader(1024 * 1024)
            while b:
                yield b
                b = reader(1024 * 1024)
    
        with open(fname, "rb") as f:
            count = sum(buf.count(b"\n") for buf in _make_gen(f.raw.read))
        return count
    
    
  2. For files with potentially longer lines (up to 2000 characters), disregarding the number of lines: use function with mmap: count_nb_lines_mmap

    def count_nb_lines_mmap(file: Path) -> int:
        """Count the number of lines in a file"""
        with open(file, mode="rb") as f:
            mm = mmap.mmap(f.fileno(), 0, access=mmap.ACCESS_READ)
            nb_lines = 0
            while mm.readline():
                nb_lines += 1
            mm.close()
            return nb_lines
    
  3. For a short code with very good performance (especially for files of size up to medium size):

    def itercount(filename: str) -> int:
        """Count the number of lines in a file"""
        with open(filename, 'rb') as f:
            return sum(1 for _ in f)
    

Here is a summary of the different metrics (average time with timeit on 7 runs with 10 loops each):

Function Small file, short lines Small file, long lines Big file, short lines Big file, long lines Bigger file, short lines
... size ... 0.04 MB 1.16 MB 318 MB 17 MB 328 MB
... nb lines ... 915 lines < 100 chars 915 lines < 2000 chars 389000 lines < 100 chars 389,000 lines < 2000 chars 9.8 millions lines < 100 chars
count_nb_lines_blocks 0.183 ms 1.718 ms 36.799 ms 415.393 ms 517.920 ms
count_nb_lines_mmap 0.185 ms 0.582 ms 44.801 ms 185.461 ms 691.637 ms
buf_count_newlines_gen 0.665 ms 1.032 ms 15.620 ms 213.458 ms 318.939 ms
itercount 0.135 ms 0.817 ms 31.292 ms 223.120 ms 628.760 ms

Note: I have also compared count_nb_lines_mmap and buf_count_newlines_gen on a file of 8 GB, with 9.7 million lines of more than 800 characters. We got an average of 5.39 seconds for buf_count_newlines_gen vs. 4.2 seconds for count_nb_lines_mmap, so this latter function seems indeed better for files with longer lines.

Here is the code I have used:

import mmap
from pathlib import Path

def count_nb_lines_blocks(file: Path) -> int:
    """Count the number of lines in a file"""

    def blocks(files, size=65536):
        while True:
            b = files.read(size)
            if not b:
                break
            yield b

    with open(file, encoding="utf-8", errors="ignore") as f:
        return sum(bl.count("\n") for bl in blocks(f))


def count_nb_lines_mmap(file: Path) -> int:
    """Count the number of lines in a file"""
    with open(file, mode="rb") as f:
        mm = mmap.mmap(f.fileno(), 0, access=mmap.ACCESS_READ)
        nb_lines = 0
        while mm.readline():
            nb_lines += 1
        mm.close()
        return nb_lines


def count_nb_lines_sum(file: Path) -> int:
    """Count the number of lines in a file"""
    with open(file, "r", encoding="utf-8", errors="ignore") as f:
        return sum(1 for line in f)


def count_nb_lines_for(file: Path) -> int:
    """Count the number of lines in a file"""
    i = 0
    with open(file) as f:
        for i, _ in enumerate(f, start=1):
            pass
    return i


def buf_count_newlines_gen(fname: str) -> int:
    """Count the number of lines in a file"""
    def _make_gen(reader):
        b = reader(1024 * 1024)
        while b:
            yield b
            b = reader(1024 * 1024)

    with open(fname, "rb") as f:
        count = sum(buf.count(b"\n") for buf in _make_gen(f.raw.read))
    return count


def itercount(filename: str) -> int:
    """Count the number of lines in a file"""
    with open(filename, 'rbU') as f:
        return sum(1 for _ in f)


files = [small_file, big_file, small_file_shorter, big_file_shorter, small_file_shorter_sim_size, big_file_shorter_sim_size]
for file in files:
    print(f"File: {file.name} (size: {file.stat().st_size / 1024 ** 2:.2f} MB)")
    for func in [
        count_nb_lines_blocks,
        count_nb_lines_mmap,
        count_nb_lines_sum,
        count_nb_lines_for,
        buf_count_newlines_gen,
        itercount,
    ]:
        result = func(file)
        time = Timer(lambda: func(file)).repeat(7, 10)
        print(f" * {func.__name__}: {result} lines in {mean(time) / 10 * 1000:.3f} ms")
    print()
File: small_file.ndjson (size: 1.16 MB)
 * count_nb_lines_blocks: 915 lines in 1.718 ms
 * count_nb_lines_mmap: 915 lines in 0.582 ms
 * count_nb_lines_sum: 915 lines in 1.993 ms
 * count_nb_lines_for: 915 lines in 3.876 ms
 * buf_count_newlines_gen: 915 lines in 1.032 ms
 * itercount: 915 lines in 0.817 ms

File: big_file.ndjson (size: 317.99 MB)
 * count_nb_lines_blocks: 389000 lines in 415.393 ms
 * count_nb_lines_mmap: 389000 lines in 185.461 ms
 * count_nb_lines_sum: 389000 lines in 485.370 ms
 * count_nb_lines_for: 389000 lines in 967.075 ms
 * buf_count_newlines_gen: 389000 lines in 213.458 ms
 * itercount: 389000 lines in 223.120 ms

File: small_file__shorter.ndjson (size: 0.04 MB)
 * count_nb_lines_blocks: 915 lines in 0.183 ms
 * count_nb_lines_mmap: 915 lines in 0.185 ms
 * count_nb_lines_sum: 915 lines in 0.251 ms
 * count_nb_lines_for: 915 lines in 0.244 ms
 * buf_count_newlines_gen: 915 lines in 0.665 ms
 * itercount: 915 lines in 0.135 ms

File: big_file__shorter.ndjson (size: 17.42 MB)
 * count_nb_lines_blocks: 389000 lines in 36.799 ms
 * count_nb_lines_mmap: 389000 lines in 44.801 ms
 * count_nb_lines_sum: 389000 lines in 59.068 ms
 * count_nb_lines_for: 389000 lines in 81.387 ms
 * buf_count_newlines_gen: 389000 lines in 15.620 ms
 * itercount: 389000 lines in 31.292 ms

File: small_file__shorter_sim_size.ndjson (size: 1.21 MB)
 * count_nb_lines_blocks: 36457 lines in 1.920 ms
 * count_nb_lines_mmap: 36457 lines in 2.615 ms
 * count_nb_lines_sum: 36457 lines in 3.993 ms
 * count_nb_lines_for: 36457 lines in 6.011 ms
 * buf_count_newlines_gen: 36457 lines in 1.363 ms
 * itercount: 36457 lines in 2.147 ms

File: big_file__shorter_sim_size.ndjson (size: 328.19 MB)
 * count_nb_lines_blocks: 9834248 lines in 517.920 ms
 * count_nb_lines_mmap: 9834248 lines in 691.637 ms
 * count_nb_lines_sum: 9834248 lines in 1109.669 ms
 * count_nb_lines_for: 9834248 lines in 1683.859 ms
 * buf_count_newlines_gen: 9834248 lines in 318.939 ms
 * itercount: 9834248 lines in 628.760 ms
Infinite answered 8/5, 2023 at 3:19 Comment(2)
Nice comparison BUT Big file, long lines with a 17mb size is not that big !!Criminology
@Enissay. It's not very big indeed, but still 389,000 lines so no short :) I did some tests on 8 GB text files: this was big ;)Infinite
L
3

If one wants to get the line count cheaply in Python in Linux, I recommend this method:

import os
print os.popen("wc -l file_path").readline().split()[0]

file_path can be both abstract file path or relative path. Hope this may help.

Leeleeann answered 28/8, 2014 at 9:9 Comment(0)
T
3

This is a meta-comment on some of the other answers.

  1. The line-reading and buffered \n-counting techniques won't return the same answer for every file, because some text files have no newline at the end of the last line. You can work around this by checking the last byte of the last nonempty buffer and adding 1 if it's not b'\n'.

  2. In Python 3, opening the file in text mode and in binary mode can yield different results, because text mode by default recognizes CR, LF, and CRLF as line endings (converting them all to '\n'), while in binary mode only LF and CRLF will be counted if you count b'\n'. This applies whether you read by lines or into a fixed-size buffer. The classic Mac OS used CR as a line ending; I don't know how common those files are these days.

  3. The buffer-reading approach uses a bounded amount of RAM independent of file size, while the line-reading approach could read the entire file into RAM at once in the worst case (especially if the file uses CR line endings). In the worst case it may use substantially more RAM than the file size, because of overhead from dynamic resizing of the line buffer and (if you opened in text mode) Unicode decoding and storage.

  4. You can improve the memory usage, and probably the speed, of the buffered approach by pre-allocating a bytearray and using readinto instead of read. One of the existing answers (with few votes) does this, but it's buggy (it double-counts some bytes).

  5. The top buffer-reading answer uses a large buffer (1 MiB). Using a smaller buffer can actually be faster because of OS readahead. If you read 32K or 64K at a time, the OS will probably start reading the next 32K/64K into the cache before you ask for it, and each trip to the kernel will return almost immediately. If you read 1 MiB at a time, the OS is unlikely to speculatively read a whole megabyte. It may preread a smaller amount but you will still spend a significant amount of time sitting in the kernel waiting for the disk to return the rest of the data.

Tinner answered 14/8, 2020 at 17:52 Comment(0)
K
3

There are a lot of answers already, but unfortunately most of them are just tiny economies on a barely optimizable problem...

I worked on several projects where line count was the core function of the software, and working as fast as possible with a huge number of files was of paramount importance.

The main bottleneck with line count is I/O access, as you need to read each line in order to detect the line return character, there is simply no way around. The second potential bottleneck is memory management: the more you load at once, the faster you can process, but this bottleneck is negligible compared to the first.

Hence, there are three major ways to reduce the processing time of a line count function, apart from tiny optimizations such as disabling GC collection and other micro-managing tricks:

  1. Hardware solution: the major and most obvious way is non-programmatic: buy a very fast SSD/flash hard drive. By far, this is how you can get the biggest speed boosts.

  2. Data preprocessing and lines parallelization: if you generate or can modify how the files you process are generated, or if it's acceptable that you can preprocess them. First convert the line return to Unix style (\n) as this will save 1 character compared to Windows (not a big save, but it's an easy gain), and secondly and most importantly, you can potentially write lines of fixed length. If you need variable length, you can pad smaller lines if the length variability is not that big. This way, you can calculate instantly the number of lines from the total file size, which is much faster to access. Also, by having fixed length lines, not only can you generally pre-allocate memory which will speed up processing, but also you can process lines in parallel! Of course, parallelization works better with a flash/SSD disk that has much faster random access I/O than HDDs.. Often, the best solution to a problem is to preprocess it so that it better fits your end purpose.

  3. Disks parallelization + hardware solution: if you can buy multiple hard disks (and if possible SSD flash disks), then you can even go beyond the speed of one disk by leveraging parallelization, by storing your files in a balanced way (easiest is to balance by total size) among disks, and then read in parallel from all those disks. Then, you can expect to get a multiplier boost in proportion with the number of disks you have. If buying multiple disks is not an option for you, then parallelization likely won't help (except if your disk has multiple reading headers like some professional-grade disks, but even then the disk's internal cache memory and PCB circuitry will likely be a bottleneck and prevent you from fully using all heads in parallel, plus you have to devise a specific code for this hard drive you'll use because you need to know the exact cluster mapping so that you store your files on clusters under different heads, and so that you can read them with different heads after). Indeed, it's commonly known that sequential reading is almost always faster than random reading, and parallelization on a single disk will have a performance more similar to random reading than sequential reading (you can test your hard drive speed in both aspects using CrystalDiskMark for example).

If none of those are an option, then you can only rely on micromanaging tricks to improve by a few percents the speed of your line counting function, but don't expect anything really significant. Rather, you can expect the time you'll spend tweaking will be disproportionate compared to the returns in speed improvement you'll see.

Knighten answered 9/11, 2020 at 19:12 Comment(1)
I don't think macOS uses two characters (only Windows). Classic Mac OS certainly didn't (just 13 (decimal) instead of 10 (decimal)).Innermost
H
2
print open('file.txt', 'r').read().count("\n") + 1
Hoofbeat answered 21/3, 2014 at 6:10 Comment(0)
O
2

Simple methods:

  1. Method 1

    >>> f = len(open("myfile.txt").readlines())
    >>> f
    

    Output:

    430
    
  2. Method 2

    >>> f = open("myfile.txt").read().count('\n')
    >>> f
    

    Output:

    430
    
  3. Method 3

    num_lines = len(list(open('myfile.txt')))
    
Osborne answered 17/9, 2018 at 10:27 Comment(3)
In this example file is not closed.Topfull
why did you give 3 options? how are they different? what are the benefits and drawbacks to each of these?Soot
Please add an explanation. Thanks in advance.Innermost
C
2

Using Numba

We can use Numba to JIT (Just in time) compile our function to machine code. def numbacountparallel(fname) runs 2.8x faster than def file_len(fname) from the question.

Notes:

The OS had already cached the file to memory before the benchmarks were run as I don't see much disk activity on my PC. The time would be much slower when reading the file for the first time making the time advantage of using Numba insignificant.

The JIT compilation takes extra time the first time the function is called.

This would be useful if we were doing more than just counting lines.

Cython is another option.

Conclusion

As counting lines will be I/O bound, use the def file_len(fname) from the question unless you want to do more than just count lines.

import timeit

from numba import jit, prange
import numpy as np

from itertools import (takewhile,repeat)

FILE = '../data/us_confirmed.csv' # 40.6MB, 371755 line file
CR = ord('\n')


# Copied from the question above. Used as a benchmark
def file_len(fname):
    with open(fname) as f:
        for i, l in enumerate(f):
            pass
    return i + 1


# Copied from another answer. Used as a benchmark
def rawincount(filename):
    f = open(filename, 'rb')
    bufgen = takewhile(lambda x: x, (f.read(1024*1024*10) for _ in repeat(None)))
    return sum( buf.count(b'\n') for buf in bufgen )


# Single thread
@jit(nopython=True)
def numbacountsingle_chunk(bs):

    c = 0
    for i in range(len(bs)):
        if bs[i] == CR:
            c += 1

    return c


def numbacountsingle(filename):
    f = open(filename, "rb")
    total = 0
    while True:
        chunk = f.read(1024*1024*10)
        lines = numbacountsingle_chunk(chunk)
        total += lines
        if not chunk:
            break

    return total


# Multi thread
@jit(nopython=True, parallel=True)
def numbacountparallel_chunk(bs):

    c = 0
    for i in prange(len(bs)):
        if bs[i] == CR:
            c += 1

    return c


def numbacountparallel(filename):
    f = open(filename, "rb")
    total = 0
    while True:
        chunk = f.read(1024*1024*10)
        lines = numbacountparallel_chunk(np.frombuffer(chunk, dtype=np.uint8))
        total += lines
        if not chunk:
            break

    return total

print('numbacountparallel')
print(numbacountparallel(FILE)) # This allows Numba to compile and cache the function without adding to the time.
print(timeit.Timer(lambda: numbacountparallel(FILE)).timeit(number=100))

print('\nnumbacountsingle')
print(numbacountsingle(FILE))
print(timeit.Timer(lambda: numbacountsingle(FILE)).timeit(number=100))

print('\nfile_len')
print(file_len(FILE))
print(timeit.Timer(lambda: rawincount(FILE)).timeit(number=100))

print('\nrawincount')
print(rawincount(FILE))
print(timeit.Timer(lambda: rawincount(FILE)).timeit(number=100))

Time in seconds for 100 calls to each function

numbacountparallel
371755
2.8007332000000003

numbacountsingle
371755
3.1508585999999994

file_len
371755
6.7945494

rawincount
371755
6.815438
Crispen answered 23/6, 2020 at 10:53 Comment(0)
L
1

The result of opening a file is an iterator, which can be converted to a sequence, which has a length:

with open(filename) as f:
   return len(list(f))

This is more concise than your explicit loop, and avoids the enumerate.

Lauter answered 10/5, 2009 at 11:35 Comment(3)
which means that 100 Mb file will need to be read into the memory.Outset
yep, good point, although I wonder about the speed (as opposed to memory) difference. It's probably possible to create an iterator that does this, but I think it would be equivalent to your solution.Lauter
-1, it's not just the memory, but having to construct the list in memory.Sloth
D
1

This could work:

import fileinput
import sys

counter = 0
for line in fileinput.input([sys.argv[1]]):
    counter += 1

fileinput.close()
print counter
Derwon answered 19/7, 2011 at 15:55 Comment(0)
T
1

Use this one-liner:

file_length = len(open('myfile.txt', 'r').read().split('\n'))

It takes 0.003 seconds using this method to time it on a 3900-line file:

def c():
  import time
  s = time.time()
  file_length = len(open('myfile.txt', 'r').read().split('\n'))
  print time.time() - s
Toxemia answered 3/10, 2013 at 0:55 Comment(0)
G
1
def count_text_file_lines(path):
    with open(path, 'rt') as file:
        line_count = sum(1 for _line in file)
    return line_count
Goglet answered 17/12, 2017 at 14:50 Comment(3)
Could you please explain what is wrong with it if you think it is wrong? It worked for me. Thanks!Goglet
I would be interested in why this answer was downvoted, too. It iterates over the file by lines and sums them up. I like it, it is short and to the point, what's wrong with it?Sile
I believe some people like to have at least a bit text and not pure raw code. @Goglet Just add something to explain why you use rt as open mode and why this implementation performs better than the one in the original question.Infinite
O
1

An alternative for big files is using xreadlines():

count = 0
for line in open(thefilepath).xreadlines(  ): count += 1

For Python 3 please see: What substitutes xreadlines() in Python 3?

Opulent answered 18/11, 2019 at 12:47 Comment(1)
Is it really more efficient than the initial algorithm in the question?Infinite
B
0

Use this:

def file_len(fname):
  counts = itertools.count()
  with open(fname) as f: 
    for _ in f: counts.next()
  return counts.next()
Budwig answered 10/5, 2009 at 18:20 Comment(0)
I
0

Read the first 100 and the last 100 lines and estimate the average line length, and then divide the total file size through that numbers.

If you don't need an exact value this could work.

Infante answered 10/5, 2009 at 18:36 Comment(1)
I need a exact value, but the problem is that in general case line length could be fairly different. I'm afraid though that your approach won't be the most efficient one.Outset
T
0

You can use the os.path module in the following way:

import os
import subprocess
Number_lines = int( (subprocess.Popen( 'wc -l {0}'.format( Filename ), shell=True, stdout=subprocess.PIPE).stdout).readlines()[0].split()[0] )

, where Filename is the absolute path of the file.

Tiffinytiffy answered 2/11, 2014 at 3:58 Comment(2)
What has this answer to do with os.path?Precede
IndexError: list index out of rangeArsenious
R
0

Create an executable script file named count.py:

#!/usr/bin/python

import sys
count = 0
for line in sys.stdin:
    count+=1

And then pipe the file's content into the Python script: cat huge.txt | ./count.py. A pipe works also in PowerShell, so you will end up counting the number of lines.

For me, on Linux it was 30% faster than the naive solution:

count = 1
with open('huge.txt') as f:
    count += 1
Ransdell answered 30/7, 2018 at 20:10 Comment(3)
If you are using bash, why not use wc -l < huge.txt? I haven't tested to see which is faster.Jonahjonas
This would be much faster if it were put in a function so that count was a local.Frump
@DanD. What do you mean? I’ll update and profile it.Ransdell
D
0

The simplest and shortest way I would use is:

f = open("my_file.txt", "r")
len(f.readlines())
Doud answered 11/8, 2021 at 3:8 Comment(1)
This has been spotted as not memory efficient in another answer.Variola
R
-1

count = max(enumerate(open(filename)))[0]

Ruminate answered 11/3, 2011 at 21:9 Comment(2)
This give the count -1 of the true value.Gazette
Optional second argument for enumerate() is start count according to docs.python.org/2/library/functions.html#enumerateMaricela
C
-1

Similarly:

lines = 0
with open(path) as f:
    for line in f:
        lines += 1
Credit answered 5/9, 2013 at 14:8 Comment(0)
S
-1
def line_count(path):
    count = 0
    with open(path) as lines:
        for count, l in enumerate(lines, start=1):
            pass
    return count
Standoff answered 2/6, 2014 at 21:45 Comment(1)
How is that different from initial question, except for the initial count = 0 which could have been a comment?Infinite
S
-1

Another possibility:

import subprocess

def num_lines_in_file(fpath):
    return int(subprocess.check_output('wc -l %s' % fpath, shell=True).strip().split()[0])
Seibert answered 27/1, 2015 at 7:8 Comment(0)
A
-1

If the file can fit into memory, then

with open(fname) as f:
    count = len(f.read().split(b'\n')) - 1
Adumbrate answered 18/1, 2018 at 22:29 Comment(1)
This would not be much better than initial solution and indeed would consume a lot of memory.Infinite
P
-1

If all the lines in your file are the same length (and contain only ASCII characters)*, you can do the following very cheaply:

fileSize     = os.path.getsize(pathToFile)  # File size in bytes
bytesPerLine = someInteger                    # Don't forget to account for the newline character
numLines     = fileSize // bytesPerLine

*I suspect more effort would be required to determine the number of bytes in a line if Unicode characters, like é, are used.

Perineurium answered 9/8, 2018 at 20:55 Comment(0)
B
-3

Use this:

import sys

sys.stdin = open('fname', 'r')
data = sys.stdin.readlines()
print "counted", len(data), "lines"
Battiste answered 25/6, 2010 at 15:17 Comment(2)
I don't think it addresses the fact that the large file is being read into the memory.Outset
print "counted",len(data),"lines" ^ SyntaxError: invalid syntaxDogwood
A
-3

The following may work:

import sys

# Input comes from STDIN
file = sys.stdin
data = file.readlines()

# Get total number of lines in the file
lines = len(data)

print lines

In this case, the len function uses the input lines as a means of determining the length.

Antler answered 5/12, 2010 at 16:45 Comment(2)
The question is not how to get the line count, I've demonstrated in the question itself what I was doing: the question was how to do that efficiently. In your solution the whole file is read into the memory, which is at least inefficient for large files and at most impossible for huge ones.Outset
Actually it's likely very efficient except when it's impossible. :-)Refusal

© 2022 - 2024 — McMap. All rights reserved.