ASP.net MVC [HandleError] not catching exceptions

Question

In two different application, one a custom the other the sample MVC application you get with a new VS2008 MVC project, [HandleError] is not catching exceptions.

In the sample application I have:

[HandleError]
public class HomeController : Controller
{
    public ActionResult Index()
    {
        ViewData["Message"] = "Welcome to ASP.NET MVC!";
        throw new Exception();
        return View();
    }

    public ActionResult About()
    {
        return View();
    }
}

which is just the default controller with an exception being thrown for testing.

But it doesn't work. Instead of going to the default error.aspx page it shows the debug information in the browser.

The problem first cropped up in a custom application I'm working on which led me to test it with the sample application. Thinking it had something to do with changes I made in the custom application, I left the sample application completely unchanged with the exception (yuck) of the throw in the index method.

I'm stumped. What am I missing?

Badalona

Answer 1

In Web.config, change customErrors:

<system.web>
  <customErrors mode="On">
  </customErrors>

If mode is either Off or RemoteOnly, then you will see the yellow screen of death instead of the custom error page. The reasoning is that developers usually want the more detailed information on the yellow screen of death.

Pickerel

I did this and it did not work. What I've discovered is that in an MVC2 applciation there are more than one Web.config files in the default template. You need to apply the customErrors tag into the root-most Web.config in your solution. – Larrikin

@Mike, that's true of all MVC versions. – Pickerel

did not work for me.. check my question : #11231665 – Adabelle

Answer 2

Important: Be careful that your error page itself does not have an error on it!

If it does you'll end up with that ASP.NET custom error page and end up going round in circles and tearing your hair out. Just strip everything out of the page that could possibly cause an error and test it.

Also with respect to 'customErrors' being ON or OFF there are several contributing factors to whether or not the friendly error page (your Errors.aspx) page will be shown or not.

See this blog (except below)

HttpContext.IsCustomErrorEnabled - looks at three different sources

1. The web.config's <deployment> section's retail property. This is a useful property to set when deploying your application to a production server. This overrides any other settings for custom errors.
2. The web.config's <customErrors> section's mode property. This setting indicates whether custom errors are enabled at all, and if so whether they are enabled only for remote requests.
3. The HttpRequest object's IsLocal property. If custom errors are enabled only for remote requests, you need to know whether the request is from a remote computer.

The idea here is that you can have 'customErrors' turned OFF during development - when you do want to see the errors, and then enable it for production only.

This MSDN article discusses the attribute further.

Plat

Answer 3

Another reason for this problem may be ,

In Template MVC Application (generated by VS2008 / VS2008 Express) , Error.aspx (generated by VS) uses Master Page.

If Master Page access any ViewData it will throw null reference Exception , then the error.aspx won't be shown.

Use this Simple code as your Error.aspx , it will solve the problem, (along with CustomErrors=On )

<%@ Page Language="C#"  Inherits="System.Web.Mvc.ViewPage<System.Web.Mvc.HandleErrorInfo>" %>
<%= Model.Exception.Message %>

Disease

"If Master Page access any ViewData it will throw null reference Exception" that line brought sanity back to me. Thank You! – Metzger

Answer 4

I have struggled with this as well and I believe I understand the problem now.

In short the requirements for having [HandleError] work as expected are:

You must enable custom errors in web.config AND you must also specify where your error view is in the <customErrors> tag.

Example:

<customErrors mode="On" defaultRedirect="Error" />

Leaving off the defaultRedirect="Error" part will instead yield a 500 error in the browser--NOT the ASP.NET error page (YSOD).

Also you do not have to be in Release mode. I tested this with a Debug build and it worked fine.

My environment was Visual Studio 2010 using .NET 4 and the standard, "ASP.NET MVC 2 Web Application" project template.

What confused me was the MSDN documentation for the HandleErrorAttribute Class. It doesn't explicitly say you must turn on custom errors in web.config. And I assumed all I needed was the [Handle Error] attribute.

Topfull

Did exactly that and still having the same problem. more details here: #11231665 – Adabelle

Answer 5

There is some silly situation which once happened with me, so might be helpfull for someone.

Be sure that you've added <customErrors mode="On" /> to the correct web.config file.

---

Sometimes (especially, when you work with something like Resharper, and open your files with typing their name, but not via Solution Explorer), you can simply open a web.config either from Views folder or even from another project.

Dis

I'll never know why they decided they needed two web configs :( – Hullabaloo

The "second" one is for Razor engine itself. Potentially you can place your views anywhere, so the project might not have the web.config (as for the web project) or you want your separate settings. I agree, it might have be done in some other way to prevent such mistakes in codding, but generally it has a sense. – Dis

Answer 6

Watch out: in my case I was trying to get the HandleError attribute to catch an exception thrown inside the Controllers constructor! Of course it won't catch it. The HandleError attribute only catches exceptions thrown inside Controller actions. It's right there in the MSDN page (should've paid more attention to that):

Represents an attribute that is used to handle an exception that is thrown by an action method.

Another thing that was happening is that the Controller's OnException(ExceptionContext exceptionContext) overridden method was never being called. Again: of course it would not be called since I was throwing an exception inside the Controller's constructor.

I spent 1 hour trying to figure this out. :o) Hope it helps the next soul...

As a hint: remember that the HandleError attribute only catches 500 errors. For the other ones you should declare the <customErrors> section in Web.config:

<customErrors mode="On">
  <error statusCode="403" redirect="~/403" />
  <error statusCode="404" redirect="~/404" />
</customErrors>

Monovalent