Can inversion of control and RAII play together?
Asked Answered
M

3

6

I was just reading up on inversion of control (IOC) and it bothered me that it seems like it makes memory management a pain. Of course it seems ioc is mostly used in garbage collected environments (Net,Java,Scripting), while my concern is in non-gc settings.

My concern here is that IOC in a way goes against RAII, as we decouple resource lifetime from object lifetime. Doesn't this added complexity bother anyone else? And the real question, what techniques can be used to make things go smoothly?

Meeting answered 10/10, 2009 at 15:59 Comment(1)
See also #988261 and unity.codeplex.com/Thread/View.aspx?ThreadId=38588Skimmia
P
3

For this very reason I've made my own IoC container which returns (in C#/.NET) disposable service wrappers, that when disposed of, will "do the right thing" in regards to the service.

Be it:

  • Do nothing, when:
    • The object does not implement IDisposable
    • Is not container-scoped (in which case the container will keep track of it and return the same object more than once, and when the container is disposed of, the object will be too)
    • It is not pooled
    • It is not singleton-scoped (same as container-scoped, but a hierarchy of containers will store the singleton-scoped service in the topmost container)
  • Dispose of the service (it has factory scope, and implements IDisposable)
  • Return it to the pool

This means that all code that uses my services is inside a using-block, but the intent is more clear, at least to me:

using (var service = container.Resolve<ISomeService>())
{
    service.Instance.SomeMethod();
}

basically it says: resolve a service, call SomeMethod on the service instance, and then dispose of the service.

Since knowledge of whether to dispose of the service instance or not isn't available to the consumer, there was either the choice of just ignoring IDisposable implementations altogether, or to dispose of all services which implement IDisposable. Neither was a good solution to me. The third choice was to wrap the service instance in an object that knew what to do with the service once the wrapper was disposed of.

Paraguay answered 10/10, 2009 at 16:25 Comment(1)
Sometimes duck-typing IDisposable ends up being unavoidable (as when using foreach on a type which implements a usable GetEnumerator() method but does not implement IEnumerable<T>), but it's a major smell since as you note the fact that a class holds a reference to something that implements IDisposable does not always imply that it "owns" the object referred to thereby.Disturbing
C
1

Yes and no. IoC doesn't decouple resource lifetime from object lifetime, it decouples method invocation scope from object lifetime - you very often want object which would be destroyed at the end of a method to exist until another IoC call is made. So you either have to move the locals of a method into class scope, and ensure no method is re-entrant, or adopt another approach, such as having an extra 'environment' passed around to allow objects to be owned by that, and destroyed in subsequent IoC method calls. Either approach gets quite complicated if you want a general purpose event driven system - either your models end up having to implement explicit recursion and iteration themselves, or your simple RAII C++ code rapidly becomes a very complex nest of callbacks - sufficiently complex that I gave up on C++ and RAII started working on kin instead.

Clint answered 10/10, 2009 at 16:18 Comment(0)
M
0

The first thing I could think of was SmartPointers. And template arguments. But I'm not sure if template arguments count as an IOC technique, although I think they should. At least these can alleviate some issues with IOC, but not totally sold on the idea.

Meeting answered 10/10, 2009 at 16:2 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.