C# pass by value vs. pass by reference
Asked Answered
O

9

26

Consider the following code (I have purposefully written MyPoint to be a reference type for this example)

public class MyPoint
{
    public int x;
    public int y;
}

It is universally acknowledged (in C# at least) that when you pass by reference, the method contains a reference to the object being manipulated, whereas when you pass by value, the method copies the value being manipulated, thus the value in global scope is not affected.

Example:

void Replace<T>(T a, T b)
{
    a = b;
}

int a = 1;
int b = 2;

Replace<int>(a, b);

// a and b remain unaffected in global scope since a and b are value types.

Here is my problem; MyPoint is a reference type, thus I would expect the same operation on Point to replace a with b in global scope.

Example:

MyPoint a = new MyPoint { x = 1, y = 2 };
MyPoint b = new MyPoint { x = 3, y = 4 };

Replace<MyPoint>(a, b);

// a and b remain unaffected in global scope since a and b...ummm!?

I expected a and b to point to the same reference in memory...can someone please clarify where I have gone wrong?

Ott answered 13/4, 2015 at 13:25 Comment(1)
None of your examples uses ref or out, so they all pass (a reference) by value.Letitialetizia
S
76

Re: OP's Assertion

It is universally acknowledged (in C# at least) that when you pass by reference, the method contains a reference to the object being manipulated, whereas when you pass by value, the method copies the value being manipulated ...

TL;DR

Reference / Value Types and Passing By Reference / Value are different concepts.

Unless you use the ref or out keywords, C# passes variables to methods by value, irrespective of whether the variable is a value type or a reference type.

However, things can get complicated pretty quickly, so I would recommend avoiding passing by reference if possible (instead, if you need to return multiple values from a function, use a composite class, struct, or tuples as a return type instead of using the ref or out keywords on parameters)

Also, when passing reference types around, a lot of bugs can be avoided by not changing (mutating) fields and properties of an object passed into a method (for example, use C#'s immutable properties to prevent changes to properties, and strive to assign properties only once, during construction).

The reasoning is:

  • If passed by reference, then the called function may change the variable's address at the call-site (i.e. change the original calling function's variable's assignment).

  • If a variable is passed by value:

    • if the called function re-assigns the variable, this change is local to the called function only, and will not affect the original variable in the calling function
    • however, if changes are made to the variable's fields or properties by the called function, it will depend on whether the variable is a value type or a reference type in order to determine whether the calling function will observe the changes made to this variable.

In Detail

The problem is that there are two distinct concepts:

  • Value Types (e.g. int) vs Reference Types (e.g. string, or custom classes)
  • Passing by Value (default behaviour) vs Passing by Reference(ref, out)

Unless you explicitly pass (any) variable by reference, by using the out or ref keywords, parameters are passed by value in C#, irrespective of whether the variable is a value type or reference type.

When passing value types (such as int, float or structs like DateTime) by value (i.e. without out or ref), the called function gets a copy of the entire value type (via the stack).

Any change to the value type, and any changes to any properties / fields of the copy will be lost when the called function is exited.

However, when passing reference types (e.g. custom classes like your MyPoint class) by value, it is the reference to the same, shared object instance which is copied and passed on the stack.

This means that:

  • If the passed object has mutable (settable) fields and properties, any changes to those fields or properties of the shared object are permanent (i.e. any changes to x or y are seen by anyone observing the object)
  • However, during method calls, the reference itself is still copied (passed by value), so if the parameter variable is reassigned, this change is made only to the local copy of the reference, so the change will not be seen by the caller. This is why your code doesn't work as expected

What happens here:

void Replace<T>(T a, T b) // Both a and b are passed by value
{
    a = b;  // reassignment is localized to method `Replace`
}

for reference types T, means that the local variable (stack) reference to the object a is reassigned to the local stack reference b. This reassign is local to this function only - as soon as scope leaves this function, the re-assignment is lost.

If you really want to replace the caller's references, you'll need to change the signature like so:

void Replace<T>(ref T a, T b) // a is passed by reference
{
    a = b;   // a is reassigned, and is also visible to the calling function
}

This changes the call to call by reference - in effect we are passing the address of the caller's variable to the function, which then allows the called method to alter the calling method's variable.

However, nowadays:

  • Passing by reference is generally regarded as a bad idea - instead, we should either pass return data in the return value, and if there is more than one variable to be returned, then use a Tuple or a custom class or struct which contains all such return variables.
  • Changing ('mutating') a shared value (and even reference) variable in a called method is frowned upon, especially by the Functional Programming community, as this can lead to tricky bugs, especially when using multiple threads. Instead, give preference to immutable variables, or if mutation is required, then consider changing a (potentially deep) copy of the variable. You might find topics around 'pure functions' and 'const correctness' interesting further reading.

Edit

These two diagrams may help with the explanation.

Pass by value (reference types):

In your first instance (Replace<T>(T a,T b)), a and b are passed by value. For reference types, this means the references are copied onto the stack and passed to the called function.

enter image description here

  1. Your initial code (I've called this main) allocates two MyPoint objects on the managed heap (I've called these point1 and point2), and then assigns two local variable references a and b, to reference the points, respectively (the light blue arrows):
MyPoint a = new MyPoint { x = 1, y = 2 }; // point1
MyPoint b = new MyPoint { x = 3, y = 4 }; // point2
  1. The call to Replace<Point>(a, b) then pushes a copy of the two references onto the stack (the red arrows). Method Replace sees these as the two parameters also named a and b, which still point to point1 and point2, respectively (the orange arrows).

  2. The assignment, a = b; then changes the Replace methods' a local variable such that a now points to the same object as referenced by b (i.e. point2). However, note that this change is only to Replace's local (stack) variables, and this change will only affect subsequent code in Replace (the dark blue line). It does NOT affect the calling function's variable references in any way, NOR does this change the point1 and point2 objects on the heap at all.

Pass by reference:

If however we we change the call to Replace<T>(ref T a, T b) and then change main to pass a by reference, i.e. Replace(ref a, b):

enter image description here

  1. As before, two point objects allocated on the heap.

  2. Now, when Replace(ref a, b) is called, while mains reference b (pointing to point2) is still copied during the call, a is now passed by reference, meaning that the "address" to main's a variable is passed to Replace.

  3. Now when the assignment a = b is made ...

  4. It is the the calling function, main's a variable reference which is now updated to reference point2. The change made by the re-assignment to a is now seen by both main and Replace. There are now no references to point1

Changes to (heap allocated) object instances are seen by all code referencing the object

In both scenarios above, no changes were actually made to the heap objects, point1 and point2, it was only local variable references which were passed and re-assigned.

However, if any changes were actually made to the heap objects point1 and point2, then all variable references to these objects would see these changes.

So, for example:

void main()
{
   MyPoint a = new MyPoint { x = 1, y = 2 }; // point1
   MyPoint b = new MyPoint { x = 3, y = 4 }; // point2

   // Passed by value, but the properties x and y are being changed
   DoSomething(a, b);

   // a and b have been changed!
   Assert.AreEqual(53, a.x);
   Assert.AreEqual(21, b.y);
}

public void DoSomething(MyPoint a, MyPoint b)
{
   a.x = 53;
   b.y = 21;
}

Now, when execution returns to main, all references to point1 and point2, including main's variables a and b, which will now 'see' the changes when they next read the values for x and y of the points. You will also note that the variables a and b were still passed by value to DoSomething.

Changes to value types affect the local copy only

Value types (primitives like System.Int32, System.Double) and structs (like System.DateTime, or your own structs) are allocated on the stack, not the heap, and are copied verbatim onto the stack when passed into a call. This leads to a major difference in behaviour, since changes made by the called function to a value type field or property will only be observed locally by the called function, because it only will be mutating the local copy of the value type.

e.g. Consider the following code with an instance of the mutable struct, System.Drawing.Rectangle

public void SomeFunc(System.Drawing.Rectangle aRectangle)
{
    // Only the local SomeFunc copy of aRectangle is changed:
    aRectangle.X = 99;
    // Passes - the changes last for the scope of the copied variable
    Assert.AreEqual(99, aRectangle.X);
}  // The copy aRectangle will be lost when the stack is popped.

// Which when called:
var myRectangle = new System.Drawing.Rectangle(10, 10, 20, 20);
// A copy of `myRectangle` is passed on the stack
SomeFunc(myRectangle);
// Test passes - the caller's struct has NOT been modified
Assert.AreEqual(10, myRectangle.X);

The above can be quite confusing and highlights why it is good practice to create your own custom structs as immutable.

The ref keyword works similarly to allow value type variables to be passed by reference, viz that the 'address' of the caller's value type variable is passed onto the stack, and assignment of the caller's assigned variable is now directly possible.

Deep vs Shallow Copies when passing reference types by Value

Somewhat related, historically it was quite common to pass reference types by value, by making a deep copy of the original reference object (nested, if the object is composite), e.g. in C++ by using a copy constructor. This was typically done for reasons such as thread safety or to protect against mutation. Modern collected languages tend to avoid copy constructors, instead using immutability / readonly / const correctness approaches, allowing reference types to be shared, even in parallel environments, without fear of mutation when passing references around.

Passing copies of reference types is still commonly done, but through serialization (e.g. in Actor Model), allowing for passing of reference types across processes and across networks.

Spontaneous answered 13/4, 2015 at 13:30 Comment(6)
As a beginner I need to read this a few times to understand it. Thank you for diagrams.Sassoon
In the OP's MyPoint class, x and y are of type int, which is a value type. If we wanted to design a method that would modify a MyPoint object's x and y values e.g., Transpose(Mypoint p), you'd need to declare p with ref like so: Transpose(ref MyPoint p) right?Titled
@MinhTran - No, no special decoration is required - if MyPoint is a reference type (class) and it's properties / fields are mutable (i.e. can be changed), then the MyPoint instance is in effect shared (on the heap) by both caller and callee, and any changes to the fields by either caller or callee will be seen by everyone sharing this variable. What you might be missing is that fields on a object (class instance) will also be on the heap. This differs from passing a scalar value type as a parameter to a method. This might helpSpontaneous
@Spontaneous In your last code snippet, you've initialized myRectangle on the heap in the "calling scope" and passed it into SomeFunc(Rectangle) which assigns to Rectangle.X the value 99. I take Rectangle.X is a System.Int32 or some other integer value type. Since myRectangle.X is a mutable field of myRectangle, it also exists on the heap so the assignment aRectangle.X = 99 inside SomeFunc() should have been visible in the calling scope. Yet Assert.AreEqual(10, myRectangle.X) which indicates the calling scope did not observe the change.Titled
So this is why it is all so complicated. Rectangle is a struct which is a value type. So it is copied onto the stack and that's why the change isn't reflected. I would suggest that you try your own examples with both a class and struct. But I would suggest in practice that you strive to make your classes and structs immutable where possible and avoid the temptation to mutate shared instances, and avoid passing by reference. It will save a lot of bugs.Spontaneous
Related discussion on heap and reference type allocation here : https://mcmap.net/q/10286/-arrays-heap-and-stack-and-value-typesSpontaneous
M
7

C# is actually pass by value. You get the illusion it's pass by reference, because when you pass a reference type you get a copy of the reference (the reference was passed by value). However, since your replace method is replacing that reference copy with another reference, it's effectively doing nothing (The copied reference goes out of scope immediately). You can actually pass by reference by adding the ref keyword:

void Replace<T>(ref T a, T b)
{
    a = b;
}

This will get you your desired result, but in practice is a little strange.

Mesomorph answered 13/4, 2015 at 13:29 Comment(0)
D
5

C# is passing reference types objects not by reference, but rather it's passing the reference by value. Meaning you can mess around with their insides, but you can't change the assignment itself.

Read this great piece by Jon Skeet for deeper understanding.

Dunsany answered 13/4, 2015 at 13:29 Comment(0)
M
3

In C# all the params that you pass to a method are passed by value.
Now before you shout keep on reading:

A value-type's value is the data that is copied while a reference type's value is actually a reference.

So when you pass an objects reference to a method and change that object then the changes will reflect outside the method as well since you are manipulating the same memory the object was allocated.

public void Func(Point p){p.x = 4;}
Point p = new Point {x=3,y=4};
Func(p);
// p.x = 4, p.y = 4

Now Lets look at this method:

public void Func2(Point p){
 p = new Point{x=5,y=5};
}
Func2(p);
// p.x = 4, p.y = 4

So no changed occurred here and why? Your method simply created a new Point and changed p's reference(Which was passed by value) and therefore the change was local. You didn't manipulate the point, you changed the reference and you did locally.

And there comes the ref keyword that saves the day:

public void Func3(ref Point p){
 p = new Point{x=5,y=5};
}
Func3(ref p);
// p.x = 5, p.y = 5

The same occurred in your example. You assigned a point with a new reference, but you did it locally.

Mathamathe answered 13/4, 2015 at 13:34 Comment(0)
A
2

Have a look on behavior by a simple program in C#:

class Program
{
    static int intData = 0;
    static string stringData = string.Empty;

    public static void CallByValueForValueType(int data)
    {
        data = data + 5;
    }

    public static void CallByValueForRefrenceType(string data)
    {
        data = data + "Changes";
    }


    public static void CallByRefrenceForValueType(ref int data)
    {
        data = data + 5;
    }


    public static void CallByRefrenceForRefrenceType(ref string data)
    {
        data = data  +"Changes";
    }


    static void Main(string[] args)
    {
        intData = 0;
        CallByValueForValueType(intData);
        Console.WriteLine($"CallByValueForValueType : {intData}");

        stringData = string.Empty;
        CallByValueForRefrenceType(stringData);
        Console.WriteLine($"CallByValueForRefrenceType : {stringData}");

        intData = 0;
        CallByRefrenceForValueType(ref intData);
        Console.WriteLine($"CallByRefrenceForValueType : {intData}");

        stringData = string.Empty;
        CallByRefrenceForRefrenceType(ref stringData);
        Console.WriteLine($"CallByRefrenceForRefrenceType : {stringData}");

        Console.ReadLine();
    }
}

Output: enter image description here

Argentiferous answered 2/12, 2019 at 5:59 Comment(0)
Q
0

You're not understanding what passing by reference means. Your Replace method is creating a copy of the Point object--passing by value (which is actually the better way of doing it).

To pass by reference, so that a and b both reference the same point in memory, you need add "ref" to the signature.

Qoph answered 13/4, 2015 at 13:29 Comment(1)
The object itself is not copied, but the reference to it is. Thus, if you change anything within that class, the change will persist when you exit the function.Dunsany
R
0

You dont get it right.

It is similar like Java - everything is passed by value! But you do have to know, what the value is.

In primitive data types, the value is the number itself. In other cases it is reference.

BUT, if you copy reference to another variable, it holds same reference, but does not reference the variable (thus it is not pass by reference known in C++).

Radiophone answered 13/4, 2015 at 13:30 Comment(0)
K
0

By default c# passes ALL arguements by value... that is why a and b remain unaffected in global scope in your examples. Here's a reference for those down voters.

Ketcham answered 22/6, 2018 at 21:10 Comment(1)
I think the confusion for a lot of beginners is that even references are passed by valueOtt
L
0

To add more detail...in .NET, C# methods, using the default "pass by value" assigned to all parameters, reference types act differently in two scenarios. In the case of all reference types using classes (System.Object types), a copy of the "pointer" (to a memory block) to the original class or object is passed in and assigned to the method's parameter or variable name. This pointer is a value, too, and copied on the stack in memory where all value types are store. The value of the object isn't stored just a copy of its pointer, that points back to the original cl;ass object. I believe this is a 4-byte value. That's what is physically passed and stored in methods for all reference types. So, you now have a new method parameter or variable with a pointer assigned to it still pointing back to the original class object outside the method. You can now do two things to the new variable with the copied pointer value:

  1. You can change the ORIGINAL object outside the method by changing its properties iniside your method. If "MyObject" is your variable with the copied pointer, you would do MyObject.myproperty = 6;, which changed the "myproperty" inside the original object outside the method. You did this as you passed in a pointer to the original object and assigned it to a new variable in your method. Note that this DOES change the referenced object outside the method.

  2. Or, setting your variable with copied pointer to a new object and new pointer like so: MyObject = new SomeObject(); Here, we destroyed the old copied pointer assigned the variable above and assigned it to a new pointer to a new object! Now we have lost connection to the outside object and only changing a new object.

Lymphatic answered 14/8, 2021 at 18:27 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.