Executing a stored procedure inside BEGIN/END TRANSACTION
Asked Answered
A

7

54

If I create a Stored Procedure in SQL and call it (EXEC spStoredProcedure) within the BEGIN/END TRANSACTION, does this stored procedure also fall into the transaction?

I didn't know if it worked like try/catches in C#.

Alberta answered 7/10, 2008 at 19:50 Comment(0)
M
56

Yes, everything that you do between the Begin Transaction and Commit (or Rollback) is part of the transaction.

Marvismarwin answered 7/10, 2008 at 20:11 Comment(4)
This isn't completely true. Actually, operations on table variables are outside the transaction scope; a rollback does not affect any changes that have been made in your table variable.Ernaline
Well, I meant everything you do to the database - I guess I assumed it was obvious that variables are not affected by transactions - although I suppose it's a bit less intuitive with table variables than scalar variables.Marvismarwin
What if the Sp called inside the outer transation calls commit transation? Will the inner transaction be rolled back if the outer transaction calls rollback after the inner is commited?Porphyria
Yes, that is how nested transactions work. Committing the inner transaction does nothing; only the outer transaction is actually ever committed or rolled back.Marvismarwin
A
14

Sounds great, thanks a bunch. I ended up doing something like this (because I'm on 05)

    BEGIN TRY
       BEGIN TRANSACTION

       DO SOMETHING

       COMMIT
    END TRY
    BEGIN CATCH
      IF @@TRANCOUNT > 0
         ROLLBACK

      -- Raise an error with the details of the exception
      DECLARE @ErrMsg nvarchar(4000), @ErrSeverity int
      SELECT @ErrMsg = ERROR_MESSAGE(),
             @ErrSeverity = ERROR_SEVERITY()

      RAISERROR(@ErrMsg, @ErrSeverity, 1)
    END CATCH
Alberta answered 7/10, 2008 at 20:16 Comment(1)
This works! thanks! Not like the solution by KM in #2715684 which throws a network related errorPirn
M
6

I believe in MS SQL Server the stored procedure execution would happen within the transaction, but be very careful with this. If you have nested transactions (ie, transaction outside of the stored procedure and a different transaction inside the stored procedure), a rollback will affect ALL of the transactions, not just the nearest enclosing transaction.

Microlith answered 7/10, 2008 at 20:11 Comment(0)
P
6

As Chris mentioned, you should be careful about rolling the transaction back.

Specifically this:

IF @@TRANCOUNT > 0 ROLLBACK

is not always what you want. You could do something like this

IF(@@TRANCOUNT = 1) ROLLBACK TRAN
ELSE IF(@@TRANCOUNT > 1) COMMIT TRAN
RETURN @error

This way, the calling proc can inspect the return value from the stored procedure and determine if it wants to commit anyways or continue to bubble up the error.

The reason is that 'COMMIT' will just decrement your transaction counter. Once it decrements the transaction counter to zero, then an actual commit will occur.

Pachydermatous answered 7/10, 2008 at 20:42 Comment(0)
A
3

As Chris and James mentioned, you need to be careful when dealing with nested transactions. There is a set a very good articles on the subject of transactions written by Don Peterson on SQL Server Central , I would recommend having a read of those:

Here there are:

Asthenic answered 8/10, 2008 at 8:57 Comment(1)
nice articles, but i think it might be an old one as it was wrote in year 2004, nonetheless still there is a lot of relevance on subjectNittygritty
D
1

Yes, all nested stored procedure calls are included in the scope of the transaction. If you are using SQL Server 2005 or greater, you can use Try...Catch as well. Here is more detail on that.

Deservedly answered 7/10, 2008 at 20:14 Comment(0)
M
1

@Chris, I did not know that.

When googling for more info, I came across this - you can set 'savepoints', which can be rolled back to without rolling back the whole transaction.

Could be useful in this situation.

Marvismarwin answered 7/10, 2008 at 22:23 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.