Android ADT 21.0 warning: Implicitly using the default locale

Question

I've updated ADT to v. 21 and new warning appeared in this code:

if (e.getMessage().toLowerCase().contains("blabla"))

Implicitly using the default locale is a common source of bugs: Use toLowerCase(Locale) instead

So I try:

if (e.getMessage().toLowerCase(Locale.ENGLISH).contains("blabla"))

But error still remained! How fix this?

Bremser

Answer 1

You should use Locale.getDefault() especially if you cant be sure that your text will always be in english. Also lint errors like that one you are having usually disappear after you run lint again or clean your project.

Blaeberry

toUpperCase(Locale.getDefault()); and now i get Locale cannot be resolved – Megganmeggi

Don't the string functions just use Locale.getDefault() internally if you don't specify a locale? – Orphanage

What a reason to do that if it's used by default inside toUpperCase() method: <code> public String toUpperCase() { return CaseMapper.toUpperCase(Locale.getDefault(), this, count); } </code> – Fount

Hi, I don't know why "using the default locale is a common source of bugs" any bug case about that? – Sophistic

Answer 2

You simply need to clean your project by clicking:

Build > Clean Project or Build > Rebuild Project

Allgood

see my comment to previous answer – Bremser

Can you please explain "how" cleaning project removes those warnings and "why" user shouldn't do something to solve those warnings and rather just clean the project and move on? – Superclass

@Superclass You should read the question: "So I try: if (e.getMessage().toLowerCase(Locale.ENGLISH).contains("blabla")) But error still remained! How fix this?" – Parma

Answer 3

Actually, use Locale.getDefault() when the goal is to present text to the user. However, and this is the whole point of the Lint check, you should probably be using Locale.US whenever the goal is for machine readability/usage. Because it is already implicitly using Locale.getDefault() if you don't specify one, and this can cause hard to find bugs when devices have their own default locale specified. It seems that you also need to clean your project either way, as everyone else has suggested.

Family

Answer 4

use Locale.getDefault() and than clean your project.

Inductor

Answer 5

Cleaning the project didn't work for me, so I added the default locale on my code:

String.format(Locale.getDefault(), "firstname: %s, lastname: %s", firstName, lastName));

Depending on your project, you might want to take a look at the Locale explanation.

Krenn

Answer 6

It's probably a Lint bug. Just try to cut the whole line of code

if (e.getMessage().toLowerCase(Locale.ENGLISH).contains("blabla"))

save, then paste.

Bleach

I also suppose it's a bug of Lint rules. But setting Locale.ENGLISH is not a good choice, because other languages may have different rules for case converting. See #10337230 and #16928164. – Logistic

Answer 7

As written in Why does Android Lint warn about String.format using default locale when explicitly using Locale.US? and Which Locale should I specify when I call String#toLowerCase? some languages like Turkish have different rules of case converting (the 'I' and 'i' characters are not case-converted to one another).

I suppose, this is a bug of Lint rules. Setting Locale.getDefault() is a good choice. To remove the warning, add before method:

@SuppressLint("DefaultLocale") 

Logistic