There were some slips in your code, like class
instead of className
, missing key
attributes. I modified your sample, have a look here.
Its also important that reducers are pure functions - always return a new state when a change is triggered by a suitable action, don't mutate the previous state (and nested properties). If no the reducer can't handle the action, just return the previous state - don't throw in the reducer, that would also make it impure.
An alternative to your shape would be to make each child reducer responsible for some sub state of the whole state tree in order to make it more scalable and composeable (Link). So one reducer for apples, one for bananas and one oranges (first fruit type, then operation). But in principle, you can handle the shape like you want/need it.
Hope, that helps out.
Update:
If you seek an Redux-like implementation of combineReducers
for useReducer
, also have a look at Lauri's answer, though I recommend to use a different implementation for most cases. In the following sample each reducer only gets its own part ("slice") of the state, which reduces its complexity. You also can scale this solution pretty well - just add a new property + reducer:
// combine reducers ala Redux: each can handle its own slice
const combineReducers = slices => (prevState, action) =>
// I like to use array.reduce, you can also just write a for..in loop
Object.keys(slices).reduce(
(nextState, nextProp) => ({
...nextState,
[nextProp]: slices[nextProp](prevState[nextProp], action)
}),
prevState
);
// atomar reducers only get either apple or orange state
const apples = (state, action) => action.type === "ADD_APPLE" ? state + 1 : state;
const oranges = (state, action) => action.type === "ADD_ORANGE" ? state + 1 : state;
const App = () => {
const [state, dispatch] = React.useReducer(
combineReducers({ apples, oranges }), // here we create the reducer slices
{ apples: 0, oranges: 0 }
);
const handleAddApple = () => dispatch({ type: "ADD_APPLE" });
const handleAddOrange = () => dispatch({ type: "ADD_ORANGE" });
return (
<div>
<p>Apples: {state.apples}, Oranges: {state.oranges}</p>
<button onClick={handleAddApple}>add Apple</button>
<button onClick={handleAddOrange}>add Orange</button>
</div>
);
};
ReactDOM.render(<App />, document.getElementById("root"));
<script src="https://cdnjs.cloudflare.com/ajax/libs/react/16.13.0/umd/react.production.min.js" integrity="sha256-32Gmw5rBDXyMjg/73FgpukoTZdMrxuYW7tj8adbN8z4=" crossorigin="anonymous"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.13.0/umd/react-dom.production.min.js" integrity="sha256-bjQ42ac3EN0GqK40pC9gGi/YixvKyZ24qMP/9HiGW7w=" crossorigin="anonymous"></script>
<div id="root"></div>