Not able to add comments on Gerrit. It rather gets added as Draft. What am I doing wrong?

Asked 10/6, 2011 at 14:11 Answered 2/10, 2019 at 9:26

Not able to add comments on Gerrit. It rather gets added as Draft. What am I doing wrong? Others in my team are able to add comments though.

Evidence answered 10/6, 2011 at 14:11 Comment(0)

Comments are published when you make them part of a review. Post a review and the comments will be published with it. (You can score the commit as +0 if you don't have any opinion either way.)

Colpin answered 30/9, 2011 at 3:9 Comment(7)

Who could know? Gerrit has one of the worst UIs I've seen (especially "feel" part, "look" is merely OK). And that tool creeps thru the industry (press releases would call that "adoption"). Thanks Google! – Beryl 24/9, 2013 at 15:12

How do you "post" a review or "publish" the comments? I created my first review and added comments to explain my changes, and they all remained as drafts. Unfortunately I refreshed the page and all the drafts were lost. +1 about the comment about bad UI! I much prefer Code Collaborator. – Oney 30/10, 2013 at 19:59

Go back up to the main review from any file you're looking at (hotkey: u) and click the "Review" button, which should be the first one under the patchset. – Colpin 30/10, 2013 at 23:19

@Oney Click the "Reply..." button in the header of the change. – Bulge 4/5, 2015 at 10:42

duskwuff's comment is outdated or at least not applicable to the version of Gerrit I'm using. thSoft's does work. – Oxblood 6/5, 2015 at 9:38

You need to click reply in the main header after posting your comment. (hotkey: u to get to the main review), this will then let you publish the draft. – Dent 28/7, 2017 at 16:54

@Beryl I've never found a Google product with a good UI. Even the simplest thing like the google.com home page has problems. And it gets worse from there. – Hus 22/12, 2020 at 17:28

Click on the Reply button in the header. Then Post it.

Highmuckamuck answered 20/1, 2017 at 8:24 Comment(4)

As this is a popular question, I think it would be relevant for you to review how to write a good answer. Please add some references and broaden your explanation. – Presently 20/1, 2017 at 8:26

On the other hand, your answer is fully correct. And I have ran into that myself; so I see some merit. Still, consider improving it! – Laxity 20/1, 2017 at 8:51

Reply button to submit a review... so unintuitive. – Cryoscope 4/10, 2017 at 0:5

@Cryoscope For sure. This is why I hate Gerrit but I have no choice to use it where I'm currently employed. – Class 15/11, 2017 at 18:1

For those who has happened to be stumbled (like me) with how to post comments for work-in-progress (WIP) review without starting review (e.g. leaving in work-in-progress state), Gerrit version 3.4 or newer.

Here's counter-intuitive answer:

Press START REVIEW button - don't afraid, it will not start review immediately (at least on above mentioned version)
Press SEND AS WIP in opened window in right bottom corner:

Notice that in older Gerrit versions the button was named SAVE. Also it was greyed-out in even older Gerrit versions.

Dabble answered 2/10, 2019 at 9:26 Comment(1)

Extremely helpful. Thanks. – Decolonize 14/5, 2021 at 4:57

And since I am not able to add a comment :

When you want to add comments to a specific revision(Patch Set), switch to that revision and then click on reply. This "Patch Sets" option is found on the upper right corner next to "Download".

Had to learn the Hard Way today. :-/

Bartolommeo answered 1/12, 2015 at 21:24 Comment(0)

At least on Qt's Gerrit system:

After saving the comment draft, yse the keyboard shortcut 'r' to publish a "review" which publishes the comment.

Lucais answered 6/2, 2018 at 22:59 Comment(0)

Recommended topics

Hot tags