How to call a property of the base class if this property is being overwritten in the derived class?
Asked Answered
G

7

106

I'm changing some classes of mine from an extensive use of getters and setters to a more pythonic use of properties.

But now I'm stuck because some of my previous getters or setters would call the corresponding method of the base class, and then perform something else. But how can this be accomplished with properties? How to call the property getter or setter in the parent class?

Of course just calling the attribute itself gives infinite recursion.

class Foo(object):

    @property
    def bar(self):
        return 5

    @bar.setter
    def bar(self, a):
        print a

class FooBar(Foo):

    @property
    def bar(self):
        # return the same value
        # as in the base class
        return self.bar # --> recursion!

    @bar.setter
    def bar(self, c):
        # perform the same action
        # as in the base class
        self.bar = c    # --> recursion!
        # then do something else
        print 'something else'

fb = FooBar()
fb.bar = 7
Gilpin answered 20/6, 2009 at 11:37 Comment(0)
N
115

You might think you could call the base class function which is called by property:

class FooBar(Foo):

    @property
    def bar(self):
        # return the same value
        # as in the base class
        return Foo.bar(self)

Though this is the most obvious thing to try I think - it does not work because bar is a property, not a callable.

But a property is just an object, with a getter method to find the corresponding attribute:

class FooBar(Foo):

    @property
    def bar(self):
        # return the same value
        # as in the base class
        return Foo.bar.fget(self)
Natatorium answered 20/6, 2009 at 11:51 Comment(6)
Why should I call Foo.bar.fset(self, c) in an inherited setter? Why not Foo.bar.fset(c) - without the "self" -I thought this is implicitely passed?Frowst
I get a TypeError: 'property' object is not callableHarv
@Frowst where does the self get implies from the chain Foo.bar.fset?Rhythmical
Just a thought - AFAIK self is always implicitly passed. If you do a foo = Foo() \ foo.bar(c) there is no self passed, but bar() receives it from Python. I'm no Python expert, more or less a beginner too. It's just a thought.Frowst
self is only implicitly passed when the method is called on an instance of a class. For example, if I have a class A with a method b(self, arg), and I create an instance c = A(), then calling c.b(arg) is equivalent to A.b(c, arg)Forby
I thought I'd add in case someone has a reason not to want to call the first base class by name even if it obfuscates the code... Foo is self.__class__.__bases__[0] (handly trick also for super(self.__class__.__bases__[1], self).Paapanen
K
71

super() should do the trick:

return super().bar

In Python 2.x you need to use the more verbose syntax:

return super(FooBar, self).bar
Killerdiller answered 20/6, 2009 at 11:46 Comment(8)
TypeError: super() takes at least 1 argument (0 given)Palmira
I guess (well, judging by the link :P), this answer is python3-related. In python3 super() can take zero arguments, yes.Trejo
super() works without arguments in Python 3 and is equivalent to super(MyClass, self) but more readable in my book.Killerdiller
In python 2.7 I get AttributeError: 'super' object has no attribute 'bar'Harv
super().bar seems to work fine for the getter, but doesn't work for assignment through the base property in an overridden setter. If I do super().bar = 3 I get AttributeError: 'super' object has no attribute 'bar'Cognizable
Good point Rob, didn't know that. Here's more information: #10810869Killerdiller
While this works for getting, it fails for setting with an AttributeError.Octosyllabic
The above works for the getter. For the setter: super(self.__class__, self.__class__).bar.__set__(self, value) # See bugs.python.org/issue14965Knotty
B
31

There is an alternative using super that does not require to explicitly reference the base class name.

Base class A:

class A(object):
    def __init__(self):
        self._prop = None

    @property
    def prop(self):
        return self._prop

    @prop.setter
    def prop(self, value):
        self._prop = value

class B(A):
    # we want to extend prop here
    pass

In B, accessing the property getter of the parent class A:

As others have already answered, it's:

super(B, self).prop

Or in Python 3:

super().prop

This returns the value returned by the getter of the property, not the getter itself but it's sufficient to extend the getter.

In B, accessing the property setter of the parent class A:

The best recommendation I've seen so far is the following:

A.prop.fset(self, value)

I believe this one is better:

super(B, self.__class__).prop.fset(self, value)

In this example both options are equivalent but using super has the advantage of being independent from the base classes of B. If B were to inherit from a C class also extending the property, you would not have to update B's code.

Full code of B extending A's property:

class B(A):
    @property
    def prop(self):
        value = super(B, self).prop
        # do something with / modify value here
        return value

    @prop.setter
    def prop(self, value):
        # do something with / modify value here
        super(B, self.__class__).prop.fset(self, value)

One caveat:

Unless your property doesn't have a setter, you have to define both the setter and the getter in B even if you only change the behaviour of one of them.

Beefcake answered 6/6, 2016 at 17:14 Comment(3)
Hello, this is very helpful. I have a follow-up question to this. This setup works well; however, it stops working when I set init for B to define additional properties. Is there a way to have a separate init for B? Thank youSimferopol
Could you please explain how super(B, self.__class__) works exactly with super(class, class)? Where is it documented?Gecko
I've suggested some small tweaks to this answer in my answerTiemroth
T
5

Some small improvements to Maxime's answer:

  • Using __class__ to avoid writing B. Note that self.__class__ is the runtime type of self, but __class__ without self is the name of the enclosing class definition. super() is a shorthand for super(__class__, self).
  • Using __set__ instead of fset. The latter is specific to propertys, but the former applies to all property-like objects (descriptors).
class B(A):
    @property
    def prop(self):
        value = super().prop
        # do something with / modify value here
        return value

    @prop.setter
    def prop(self, value):
        # do something with / modify value here
        super(__class__, self.__class__).prop.__set__(self, value)
Tiemroth answered 19/3, 2020 at 22:51 Comment(4)
What''s unclear to me is the difference between super(__class__, self) and super(__class__, self.__class__), and why we need the latter for setting property of the ancestor class?Huttan
From the help() for super, there are two overloads - super(type, obj), which is the first case, and super(type, type2), which is the second case. We're accessing .prop as a class attribute not an instance attribute, which is why the latter is needed.Tiemroth
super(type(self), type(self)).setter.fset(self, value) doesn't work adequately with multiple inheritance. Try my solution duper(super()).setter = value: gist.github.com/willrazen/bef3fcb26a83dffb6692e5e10d3e67acEphesians
In what case does it not work adequately?Tiemroth
H
4

try

@property
def bar:
    return super(FooBar, self).bar

Although I'm not sure if python supports calling the base class property. A property is actually a callable object which is set up with the function specified and then replaces that name in the class. This could easily mean that there is no super function available.

You could always switch your syntax to use the property() function though:

class Foo(object):

    def _getbar(self):
        return 5

    def _setbar(self, a):
        print a

    bar = property(_getbar, _setbar)

class FooBar(Foo):

    def _getbar(self):
        # return the same value
        # as in the base class
        return super(FooBar, self)._getbar()

    def bar(self, c):
        super(FooBar, self)._setbar(c)
        print "Something else"

    bar = property(_getbar, _setbar)

fb = FooBar()
fb.bar = 7
Hoodoo answered 20/6, 2009 at 11:50 Comment(1)
This works fine if you write the base class. But what if you extend a third-party base class which uses the same name for the property and the getter?Daladier
O
0

You can use the following template:

class Parent():
    def __init__(self, value):
        self.__prop1 = value

    #getter
    @property
    def prop1(self):
        return self.__prop1

    #setter
    @prop1.setter
    def prop1(self, value):
        self.__prop1 = value

    #deleter
    @prop1.deleter
    def prop1(self):
        del self.__prop1
  
class Child(Parent):

    #getter
    @property
    def prop1(self):
        return super(Child, Child).prop1.__get__(self)

    #setter
    @prop1.setter
    def prop1(self, value):
        super(Child, Child).prop1.__set__(self, value)

    #deleter
    @prop1.deleter
    def prop1(self):
        super(Child, Child).prop1.__delete__(self)

Note! All of the property methods must be redefined together. If do not want to redefine all methods, use the following template instead:

class Parent():
    def __init__(self, value):
        self.__prop1 = value

    #getter
    @property
    def prop1(self):
        return self.__prop1

    #setter
    @prop1.setter
    def prop1(self, value):
        self.__prop1 = value

    #deleter
    @prop1.deleter
    def prop1(self):
        del self.__prop1


class Child(Parent):

    #getter
    @Parent.prop1.getter
    def prop1(self):
        return super(Child, Child).prop1.__get__(self)

    #setter
    @Parent.prop1.setter
    def prop1(self, value):
        super(Child, Child).prop1.__set__(self, value)

    #deleter
    @Parent.prop1.deleter
    def prop1(self):
        super(Child, Child).prop1.__delete__(self)
Ostrowski answered 5/10, 2020 at 13:1 Comment(1)
super(Child, Child) is wrong, it should be Super(Child, self.__class__)Tiemroth
T
-4
    class Base(object):
      def method(self):
        print "Base method was called"

    class Derived(Base):
      def method(self):
        super(Derived,self).method()
        print "Derived method was called"

    d = Derived()
    d.method()

(that is unless I am missing something from your explanation)

Trejo answered 20/6, 2009 at 11:51 Comment(1)
you are: he's talking about properties, not plain methodsDaladier

© 2022 - 2024 — McMap. All rights reserved.