SqlDataAdapter.Fill method slow

Question

Why would a stored procedure that returns a table with 9 columns, 89 rows using this code take 60 seconds to execute (.NET 1.1) when it takes < 1 second to run in SQL Server Management Studio? It's being run on the local machine so little/no network latency, fast dev machine

Dim command As SqlCommand = New SqlCommand(procName, CreateConnection())
command.CommandType = CommandType.StoredProcedure
command.CommandTimeout = _commandTimeOut
Try
   Dim adapter As new SqlDataAdapter(command)
   Dim i as Integer
   For i=0 to parameters.Length-1
      command.Parameters.Add(parameters(i))
   Next
   adapter.Fill(tableToFill)
   adapter.Dispose()
Finally
   command.Dispose()
End Try

my paramter array is typed (for this SQL it's only a single parameter)

parameters(0) = New SqlParameter("@UserID", SqlDbType.BigInt, 0, ParameterDirection.Input, True, 19, 0, "", DataRowVersion.Current, userID)

The Stored procedure is only a select statement like so:

ALTER PROC [dbo].[web_GetMyStuffFool]
   (@UserID BIGINT)
AS
SELECT Col1, Col2, Col3, Col3, Col3, Col3, Col3, Col3, Col3
FROM [Table]

Educe

I had the same issue and got it fixed using this article: databasejournal.com/features/mssql/article.php/3841271/… – Hoopen

This worked for me since my stored procedure does some branching based on parameters. – Ilsa

This is an old question and many people find it. Before you start cleaning the cache and playing with ARITHABORT settings, read the comprehensive article by Erland Sommarskog that explains what might be going on: Slow in the Application, Fast in SSMS? Understanding Performance Mysteries Quite often this behaviour is caused by the feature of SQL Server called "parameter sniffing". – Felicidad

Answer 1

First, make sure you are profiling the performance properly. For example, run the query twice from ADO.NET and see if the second time is much faster than the first time. This removes the overhead of waiting for the app to compile and the debugging infrastructure to ramp up.

Next, check the default settings in ADO.NET and SSMS. For example, if you run SET ARITHABORT OFF in SSMS, you might find that it now runs as slow as when using ADO.NET.

What I found once was that SET ARITHABORT OFF in SSMS caused the stored proc to be recompiled and/or different statistics to be used. And suddenly both SSMS and ADO.NET were reporting roughly the same execution time. Note that ARITHABORT is not itself the cause of the slowdown, it's that it causes a recompilation, and you are ending up with two different plans due to parameter sniffing. It is likely that parameter sniffing is the actual problem needing to be solved.

To check this, look at the execution plans for each run, specifically the sys.dm_exec_cached_plans table. They will probably be different.

Running 'sp_recompile' on a specific stored procedure will drop the associated execution plan from the cache, which then gives SQL Server a chance to create a possibly more appropriate plan at the next execution of the procedure.

Finally, you can try the "nuke it from orbit" approach of cleaning out the entire procedure cache and memory buffers using SSMS:

DBCC DROPCLEANBUFFERS
DBCC FREEPROCCACHE

Doing so before you test your query prevents usage of cached execution plans and previous results cache.

Aborning

DBCC DROPCLEANBUFFERSDBCC FREEPROCCACHE solved my problem. Does this need to be ran on a recurring basis, or only when changes are made to the stored procedure? – Lavolta

It's on a recurring basis, as these are cached results and plans that will gradually accumulate. – Aborning

Great answer, my SP execution time went from 117s to 3s! +1 – Coenosarc

The "SET ARITHABORT OFF" was a great answer! Now I get a consistent experience between ADO.NET as SSMS. In my case I just needed to rebuild one index which I did from the SSMS IDE. – Yancey

Yes.. DBCC DROPCLEANBUFFERS DBCC FREEPROCCACHE solve my problem.. but I dont want to clear cache for all objects in ssms... can I use 'exec sp_recompile' instead to solve this problem. @RoadWarrior – Raffle

@Munavvar, sorry, late to see your comment. Yes, 'sp_recompile' will clear the cache of the execution plan for a specified stored procedure. – Aborning

DBCC DROPCLEANBUFFERS approach did not work for me. – Forsworn

Answer 2

Here is what I ended up doing:

I executed the following SQL statement to rebuild the indexes on all tables in the database:

EXEC <databasename>..sp_MSforeachtable @command1='DBCC DBREINDEX (''*'')', @replacechar='*'
-- Replace <databasename> with the name of your database

If I wanted to see the same behavior in SSMS, I ran the proc like this:

SET ARITHABORT OFF
EXEC [dbo].[web_GetMyStuffFool] @UserID=1
SET ARITHABORT ON

Another way to bypass this is to add this to your code:

MyConnection.Execute "SET ARITHABORT ON"

Educe

Answer 3

I ran into the same issue, but when I've rebuilt indexes on SQL table, it worked fine, so you might want to consider rebuilding index on sql server side

Ernestinaernestine

Answer 4

Why not make it a DataReader instead of DataAdapter, it looks like you have a singel result set and if you aren't going to be pushing changes back in the DB and don't need constraints applied in .NET code you shouldn't use the Adapter.

EDIT:

If you need it to be a DataTable you can still pull the data from the DB via a DataReader and then in .NET code use the DataReader to populate a DataTable. That should still be faster than relying on the DataSet and DataAdapter

Ophidian

The code I'm working with can't return anything other than a datatable for this sproc. – Educe

Answer 5

I don't know "Why" it's so slow per se - but as Marcus is pointing out - comparing Mgmt Studio to filling a dataset is apples to oranges. Datasets contain a LOT of overhead. I hate them and NEVER use them if I can help it.

You may be having issues with mismatches of old versions of the SQL stack or some such (esp given you are obviously stuck in .NET 1.1 as well) The Framework is likely trying to do database equivilant of "Reflection" to infer schema etc etc etc

One thing to consider try with your unfortunate constraint is to access the database with a datareader and build your own dataset in code. You should be able to find samples easily via google.

Harve

and please use some using statements since your connection implements IDisposable – Carlottacarlovingian