I have an Enum called Status defined as such:
public enum Status {
VALID("valid"), OLD("old");
private final String val;
Status(String val) {
this.val = val;
}
public String getStatus() {
return val;
}
}
I would like to access the value of VALID from a JSTL tag. Specifically the test attribute of the <c:when> tag. E.g.
<c:when test="${dp.status eq Status.VALID">
I'm not sure if this is possible.
A simple comparison against string works:
<c:when test="${someModel.status == 'OLD'}">
If using Spring MVC, the Spring Expression Language (SpEL) can be helpful:
<spring:eval expression="dp.status == T(com.example.Status).VALID" var="isValid" />
<c:if test="${isValid}">
isValid
</c:if>
<c:if> and <c:when> (they fail quietly). –
Sapphirine You have 3 choices here, none of which is perfect:
You can use a scriptlet in the test attribute:
<c:when test="<%= dp.getStatus() == Status.VALID %>">
This uses the enum, but it also uses a scriptlet, which is not the "right way" in JSP 2.0. But most importantly, this doesn't work when you want to add another condition to the same when using ${}. And this means all the variables you want to test have to be declared in a scriptlet, or kept in request, or session (pageContext variable is not available in .tag files).
You can compare against string:
<c:when test="${dp.status == 'VALID'}">
This looks clean, but you're introducing a string that duplicates the enum value and cannot be validated by the compiler. So if you remove that value from the enum or rename it, you will not see that this part of code is not accessible anymore. You basically have to do a search/replace through the code each time.
You can add each of the enum values you use into the page context:
<c:set var="VALID" value="<%=Status.VALID%>"/>
and then you can do this:
<c:when test="${dp.status == VALID}">
I prefer the last option (3), even though it also uses a scriptlet. This is because it only uses it when you set the value. Later on you can use it in more complex EL expressions, together with other EL conditions. While in option (1) you cannot use a scriptlet and an EL expression in the test attribute of a single when tag.
Enum.valueOf(Class<T> enumType, String name) which will trigger an ELException if the enum has no constant with that name. The expression will not just always be false. –
Dragster So to get my problem fully resolved I needed to do the following:
<% pageContext.setAttribute("old", Status.OLD); %>
Then I was able to do:
<c:when test="${someModel.status == old}"/>...</c:when>
which worked as expected.
Here are two more possibilities:
As long as you are using at least version 3.0 of EL, then you can import constants into your page as follows:
<%@ page import="org.example.Status" %>
<c:when test="${dp.status eq Status.VALID}">
However, some IDEs don't understand this yet (e.g. IntelliJ) so you won't get any warnings if you make a typo, until runtime.
This would be my preferred method once it gets proper IDE support.
You could just add getters to your enum.
public enum Status {
VALID("valid"), OLD("old");
private final String val;
Status(String val) {
this.val = val;
}
public String getStatus() {
return val;
}
public boolean isValid() {
return this == VALID;
}
public boolean isOld() {
return this == OLD;
}
}
Then in your JSP:
<c:when test="${dp.status.valid}">
This is supported in all IDEs and will also work if you can't use EL 3.0 yet. This is what I do at the moment because it keeps all the logic wrapped up into my enum.
Also be careful if it is possible for the variable storing the enum to be null. You would need to check for that first if your code doesn't guarantee that it is not null:
<c:when test="${not empty db.status and dp.status.valid}">
I think this method is superior to those where you set an intermediary value in the JSP because you have to do that on each page where you need to use the enum. However, with this solution you only need to declare the getter once.
${MyEnum.}, put caret right after dot and press Ctrl+Space to show suggestions. –
Ketchup public enum TestEnum { AWAITING, FILE_PRESENT, FILE_NOT_FOUND; } but this doesn't: public class TestClass { public enum TestEnum { AWAITING, FILE_PRESENT, FILE_NOT_FOUND; } } Which is very frustrating as I never dedicate a whole class file to an enum! –
Skell For this purposes I do the following:
<c:set var="abc">
<%=Status.OLD.getStatus()%>
</c:set>
<c:if test="${someVariable == abc}">
....
</c:if>
It's looks ugly, but works!
I do not have an answer to the question of Kornel, but I've a remark about the other script examples. Most of the expression trust implicitly on the toString(), but the Enum.valueOf() expects a value that comes from/matches the Enum.name() property. So one should use e.g.:
<% pageContext.setAttribute("Status_OLD", Status.OLD.name()); %>
...
<c:when test="${someModel.status == Status_OLD}"/>...</c:when>
Add a method to the enum like:
public String getString() {
return this.name();
}
For example
public enum MyEnum {
VALUE_1,
VALUE_2;
public String getString() {
return this.name();
}
}
Then you can use:
<c:if test="${myObject.myEnumProperty.string eq 'VALUE_2'}">...</c:if>
When using a MVC framework I put the following in my controller.
request.setAttribute(RequestParameterNamesEnum.INBOX_ACTION.name(), RequestParameterNamesEnum.INBOX_ACTION.name());
This allows me to use the following in my JSP Page.
<script> var url = 'http://www.nowhere.com/?${INBOX_ACTION}=' + someValue;</script>
It can also be used in your comparison
<c:when test="${someModel.action == INBOX_ACTION}">
Which I prefer over putting in a string literal.
<%@ page import="com.example.Status" %>
1. ${dp.status eq Title.VALID.getStatus()}
2. ${dp.status eq Title.VALID}
3. ${dp.status eq Title.VALID.toString()}
I generally consider it bad practice to mix java code into jsps/tag files. Using 'eq' should do the trick :
<c:if test="${dp.Status eq 'OLD'}">
...
</c:if>
== instead of eq ? They do both exactly the same, so there's no means of a "trick". –
Annora I do it this way when there are many points to use...
public enum Status {
VALID("valid"), OLD("old");
private final String val;
Status(String val) {
this.val = val;
}
public String getStatus() {
return val;
}
public static void setRequestAttributes(HttpServletRequest request) {
Map<String,String> vals = new HashMap<String,String>();
for (Status val : Status.values()) {
vals.put(val.name(), val.value);
}
request.setAttribute("Status", vals);
}
}
JSP
<%@ page import="...Status" %>
<% Status.setRequestAttributes(request) %>
<c:when test="${dp.status eq Status.VALID}">
...
In Java Class:
public class EnumTest{
//Other property link
private String name;
....
public enum Status {
ACTIVE,NEWLINK, BROADCASTED, PENDING, CLICKED, VERIFIED, AWARDED, INACTIVE, EXPIRED, DELETED_BY_ADMIN;
}
private Status statusobj ;
//Getter and Setters
}
So now POJO and enum obj is created. Now EnumTest you will set in session object using in the servlet or controller class session.setAttribute("enumTest", EnumTest );
In JSP Page
<c:if test="${enumTest.statusobj == 'ACTIVE'}">
//TRUE??? THEN PROCESS SOME LOGIC
© 2022 - 2024 — McMap. All rights reserved.