Convert a preprocessor token to a string
Asked Answered
U

6

88

I'm looking for a way to convert a preprocessor token to a string.

Specifically, I've somewhere got:

#define MAX_LEN 16

and I want to use it to prevent buffer overrun:

char val[MAX_LEN+1]; // room for \0
sscanf(buf, "%"MAX_LEN"s", val);

I'm open to other ways to accomplish the same thing, but standard library only.

Unbacked answered 27/10, 2008 at 15:43 Comment(2)
#196475Nadeau
Possible duplicate of C Macros to create stringsMagnificent
C
136

See Using FILE and LINE to Report Errors:

#define STRINGIFY(x) #x
#define TOSTRING(x) STRINGIFY(x)
#define AT __FILE__ ":" TOSTRING(__LINE__)

So your problem can be solved by doing sscanf(buf, "%" TOSTRING(MAX_LEN) "s", val);.

Choriocarcinoma answered 27/10, 2008 at 15:47 Comment(5)
why cascading 2 macros? Wouldn't be one TOSTRING enough?Audile
See answer below about double-expansion stringification. The C/C++ preprocessor is dirty and ugly and I believe without a standard. So why it requires two instead of one I could not say, because I don't want to do the research.Choriocarcinoma
@Daniel Brunner A single macro will paste the token itself, yielding literally "%" "MAX_LEN" "%" a second macro causes the token value to be pasted, e.g., "16" because the TOSTRING macro makes the final code equivalent to STRINGIFY(16).Tarrah
@TimSylvester I wish I could give you rep for that comment! :)Roana
@TimSylvester That is so confusing.Levasseur
U
24

I found an answer online. ( https://gcc.gnu.org/onlinedocs/gcc-3.4.3/cpp/Stringification.html )

#define VERSION_MAJOR 4
#define VERSION_MINOR 47

#define VERSION_STRING "v" #VERSION_MAJOR "." #VERSION_MINOR

The above does not work but hopefully illustrates what I would like to do, i.e. make VERSION_STRING end up as "v4.47".

To generate the proper numeric form use something like

#define VERSION_MAJOR 4
#define VERSION_MINOR 47

#define STRINGIZE2(s) #s
#define STRINGIZE(s) STRINGIZE2(s)
#define VERSION_STRING "v" STRINGIZE(VERSION_MAJOR) \
"." STRINGIZE(VERSION_MINOR)

#include <stdio.h>
int main() {
    printf ("%s\n", VERSION_STRING);
    return 0;
}
Unbacked answered 27/10, 2008 at 15:45 Comment(1)
Re "I found an answer online.": Can you provide a reference? Related: Plagiarism flag and moderator tooling has launched to Stack Overflow!Headdress
E
12

This should work:

 sscanf(buf, "%" #MAX_LEN "s", val);

If not, it'll need to "double expansion" trick:

 #define STR1(x)  #x
 #define STR(x)  STR1(x)
 sscanf(buf, "%" STR(MAX_LEN) "s", val);
Exaggerate answered 27/10, 2008 at 15:46 Comment(2)
The first won't work; # stringizes macro arguments in macro expansions. The second will work.Detruncate
@RaviRaj — because # only stringizes macro arguments and the first line is not in the body of a macro.Detruncate
C
4

You should use the double-expansion stringification macro trick. Or just have a

#define MAX_LEN    16
#define MAX_LEN_S "16"

char val[MAX_LEN+1];
sscanf(buf, "%"MAX_LEN_S"s", val);

and keep it in sync. (That's a bit of a bother, but as long as the definitions are right next to each other, you'll probably remember.)

Actually, in this particular case, wouldn't strncpy suffice?

strncpy(val, buf, MAX_LEN);
val[MAX_LEN] = '\0';

If it were printf, though, this would be easier:

sprintf(buf, "%.*s", MAX_LEN, val);
Cepheus answered 27/10, 2008 at 20:32 Comment(1)
Yeah, I wish the * or another symbol were available for length-limiting scanf routines with an argument. sprintf in that form works better than strncpy, imo, because strncpy won't terminate the string if it overruns the buffer, and writes extra data if the string is too short.Unbacked
E
1

While some of the previous answers "work", personally I'd recommend just using a simple string API instead of the dreck that comes in libc.

There are a number of portable APIs, some of which are also optimized for ease of inclusion in your project ... and some like ustr have a tiny space overhead and support for stack variables.

Empathic answered 28/10, 2008 at 14:59 Comment(0)
M
0

In my example, the format to generate is %16s%16s%d:

#include <iostream>

#define MAX_LEN 16

#define AUX(x) #x
#define STRINGIFY(x) AUX(x)

int main() {
    char buffer[] = "Hello World 25";
    char val[MAX_LEN+1];
    char val2[MAX_LEN+1];
    int val3;

    char format[] = "%" STRINGIFY(MAX_LEN) "s" "%" STRINGIFY(MAX_LEN) "s" "%d";
    int result = sscanf(buffer, format, val, val2, &val3);
    std::cout<< val << std::endl;
    std::cout<< val2 << std::endl;
    std::cout<< val3 << std::endl;
    std::cout<<"Filled: " << result << " variables" << std::endl;
    std::cout << "Format: " << format << std::endl;
}

Output

Output

Marqueritemarques answered 14/5, 2020 at 20:11 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.