Boxing error with generic function
Asked Answered
H

1

0

If I comment out my static class this compiles fine. However i'd like to have the static class working so I can use the first commented out line in main. My error is

error CS0314: The type 'T' cannot be used as type parameter 'T' in the generic type or method 'DateTest.Range'. There is no boxing conversion or type parameter conversion from 'T' to 'System.IComparable'.

My source is

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;

namespace DateTest
{
    class Program
    {
        static void Main(string[] args)
        {
            //Range.Create(new DateTime(2013, 1, 1), new DateTime(2015, 1, 1), s => s.AddYears(1));
            new Range<DateTime>(new DateTime(2013, 1, 1), new DateTime(2015, 1, 1), s => s.AddYears(1));
        }
    }
    static class Range { public static Range<T> Create<T>(T s, T e, Func<T,T> inc) { return new Range<T>(s, e, inc); } }
    class Range<T> : IEnumerator<T> where T : IComparable 
    {
        T start, pos, end;
        Func<T,T> inc;
        public Range(T s, T e, Func<T,T> inc) { pos=start= s; end = e; this.inc = inc; }

        public T Current
        {
            get { return pos; }
        }

        public void Dispose()
        {
            throw new NotImplementedException();
        }

        object System.Collections.IEnumerator.Current
        {
            get { return pos; }
        }

        public bool MoveNext()
        {
            pos = inc(pos);
            return pos.CompareTo(end) != 0;
        }

        public void Reset()
        {
            pos = start;
        }
    }
}
Haemachrome answered 8/8, 2013 at 18:2 Comment(1)
You should constrain where T : IComparable<T>Ashraf
V
3

Your static Create methods needs to have all of the constraints on it that the Range<T> class applies to its generic argument:

static class Range
{
    public static Range<T> Create<T>(T s, T e, Func<T, T> inc)
        where T : IComparable  //this line was added
    {
        return new Range<T>(s, e, inc);
    }
}

That's all.

Since the Range class requires T to be comparable the Create method needs to ensure that its own T is also comparable.

On a side note, you may consider using IComparable<T> as the constraint for both, rather than IComparable, to ensure static typing of the comparison.

Convention would also state that Range implement IEnumerable<T> rather than IEnumerator<T> so that the same range can be iterated by multiple sources simultaneously, and it also allows you to use the type in a foreach loop and with the many other library methods (i.e. all of LINQ) that are built on the IEnumerable<T> interface.

Vespucci answered 8/8, 2013 at 18:4 Comment(1)
Ahha, idk why i thought I cant use where on functions. -edit- actually my current code implements both IEnumerable and IEnumeratorHaemachrome

© 2022 - 2024 — McMap. All rights reserved.