How can I pass selected row to commandLink inside dataTable or ui:repeat?

Question

I'm using Primefaces in a JSF 2 application. I have a <p:dataTable>, and instead of selecting rows, I want the user to be able to directly execute various actions on individual rows. For that, I have several <p:commandLink>s in the last column.

My problem: how can I pass a row ID to the action started by the command link so that I know which row to act on? I tried using an <f:attribute>:

<p:dataTable value="#{bean.items}" var="item">
    ...
    <p:column>
        <p:commandLink actionListener="#{bean.insert}" value="insert">
            <f:attribute name="id" value="#{item.id}" />
        </p:commandLink>
    </p:column>
</p:dataTable>

But it always yields 0 - apparently the row variable f is not available when the attribute is rendered (it works when I use a fixed value).

Anyone has an alternative solution?

Colliery

Answer 1

As to the cause, the <f:attribute> is specific to the component itself (populated during view build time), not to the iterated row (populated during view render time).

There are several ways to achieve the requirement.

1. If your servletcontainer supports a minimum of Servlet 3.0 / EL 2.2, then just pass it as an argument of action/listener method of UICommand component or AjaxBehavior tag. E.g.

    <h:commandLink action="#{bean.insert(item.id)}" value="insert" />
   

   In combination with:

    public void insert(Long id) {
        // ...
    }
   

   This only requires that the datamodel is preserved for the form submit request. Best is to put the bean in the view scope by @ViewScoped.

   You can even pass the entire item object:

    <h:commandLink action="#{bean.insert(item)}" value="insert" />
   

   with:

    public void insert(Item item) {
        // ...
    }
   

   On Servlet 2.5 containers, this is also possible if you supply an EL implementation which supports this, like as JBoss EL. For configuration detail, see this answer.

   ---

2. Use <f:param> in UICommand component. It adds a request parameter.

    <h:commandLink action="#{bean.insert}" value="insert">
        <f:param name="id" value="#{item.id}" />
    </h:commandLink>
   

   If your bean is request scoped, let JSF set it by @ManagedProperty

    @ManagedProperty(value="#{param.id}")
    private Long id; // +setter
   

   Or if your bean has a broader scope or if you want more fine grained validation/conversion, use <f:viewParam> on the target view, see also f:viewParam vs @ManagedProperty:

    <f:viewParam name="id" value="#{bean.id}" required="true" />
   

   Either way, this has the advantage that the datamodel doesn't necessarily need to be preserved for the form submit (for the case that your bean is request scoped).

   ---

3. Use <f:setPropertyActionListener> in UICommand component. The advantage is that this removes the need for accessing the request parameter map when the bean has a broader scope than the request scope.

    <h:commandLink action="#{bean.insert}" value="insert">
        <f:setPropertyActionListener target="#{bean.id}" value="#{item.id}" />
    </h:commandLink>
   

   In combination with

    private Long id; // +setter
   

   It'll be just available by property id in action method. This only requires that the datamodel is preserved for the form submit request. Best is to put the bean in the view scope by @ViewScoped.

   ---

4. Bind the datatable value to DataModel<E> instead which in turn wraps the items.

    <h:dataTable value="#{bean.model}" var="item">
   

   with

    private transient DataModel<Item> model;
   
    public DataModel<Item> getModel() {
        if (model == null) {
            model = new ListDataModel<Item>(items);
        }
        return model;
    }
   

   (making it transient and lazily instantiating it in the getter is mandatory when you're using this on a view or session scoped bean since DataModel doesn't implement Serializable)

   Then you'll be able to access the current row by DataModel#getRowData() without passing anything around (JSF determines the row based on the request parameter name of the clicked command link/button).

    public void insert() {
        Item item = model.getRowData();
        Long id = item.getId();
        // ...
    }
   

   This also requires that the datamodel is preserved for the form submit request. Best is to put the bean in the view scope by @ViewScoped.

   ---

5. Use Application#evaluateExpressionGet() to programmatically evaluate the current #{item}.

    public void insert() {
        FacesContext context = FacesContext.getCurrentInstance();
        Item item = context.getApplication().evaluateExpressionGet(context, "#{item}", Item.class);
        Long id = item.getId();
        // ...
    }
   

   ---

Which way to choose depends on the functional requirements and whether the one or the other offers more advantages for other purposes. I personally would go ahead with #1 or, when you'd like to support servlet 2.5 containers as well, with #2.

Royal

+1, although my preference goes to #2 (if 2.5 has to be supported). – Bowerman

Thanks for the exhaustive answer. Unfortunately, I have to report that #1 was the only thing that worked in a filtered primefaces datatable (which is exactly the scenarion I need it for). All the others only worked on an unfiltered table. I see this more as a bug in primefaces than in your answer, though. – Colliery

Is the bean request or view scoped? – Royal

With "filtered" you mean as in this showcase example? The symptoms indicate that the filter action take place in the client side only and that the model in the server side isn't maintained. Not sure if this is intentional. You can always leave an issue report. – Royal

Your post is between the most useful posts I ever read. I used method 5 because I'm forced to use servlet 2.5. My question now is if it's possible to send a parameter with commandLink (like in your example) but using ajax? – Marinemarinelli

Answer 2

In JSF 1.2 this was done by <f:setPropertyActionListener> (within the command component). In JSF 2.0 (EL 2.2 to be precise, thanks to BalusC) it's possible to do it like this: action="${filterList.insert(f.id)}

Bowerman

This feature is not specific to JSF 2.0 (which can by itself run in Servlet 2.5 containers), but to EL 2.2 (which is part of Servlet 3.0). – Royal

Answer 3

In my view page:

<p:dataTable  ...>
<p:column>
<p:commandLink actionListener="#{inquirySOController.viewDetail}" 
               process="@this" update=":mainform:dialog_content"
           oncomplete="dlg2.show()">
    <h:graphicImage library="images" name="view.png"/>
    <f:param name="trxNo" value="#{item.map['trxNo']}"/>
</p:commandLink>
</p:column>
</p:dataTable>

backing bean

 public void viewDetail(ActionEvent e) {

    String trxNo = getFacesContext().getRequestParameterMap().get("trxNo");

    for (DTO item : list) {
        if (item.get("trxNo").toString().equals(trxNo)) {
            System.out.println(trxNo);
            setSelectedItem(item);
            break;
        }
    }
}

Daysidayspring

Answer 4

Thanks to this site by Mkyong, the only solution that actually worked for us to pass a parameter was this

<h:commandLink action="#{user.editAction}">
    <f:param name="myId" value="#{param.id}" />
</h:commandLink>

with

public String editAction() {

  Map<String,String> params = 
            FacesContext.getExternalContext().getRequestParameterMap();
  String idString = params.get("myId");
  long id = Long.parseLong(idString);
  ...
}

Technically, that you cannot pass to the method itself directly, but to the JSF request parameter map.

Hypsometry

You've a different problem than asked here. You want to retain request parameters from #{param} map for subsequent requests, not to pass an arbitrary parameter. Your Q&A is covered by stackoverflow.com/questions/17734230 – Royal