WPF CommandParameter binding and canExecute
Asked Answered
T

3

6

I have a template for treeView item:

<HierarchicalDataTemplate x:Key="RatesTemplate">
    <StackPanel Orientation="Horizontal">
                        <TextBlock Text="{Binding Path=ID}"/>
                        <Button CommandParameter="{Binding Path=ID}" 
                                Command="{Binding ElementName=CalcEditView, Path=DataContext.Add}">Add</Button>                            
    </StackPanel>
</HierarchicalDataTemplate>

As a DataContext I have linq entity with ID not null field.

The problem is: if I use DelegateCommand 'Add' with CanExecutedMethod:

AddRate = new DelegateCommand<int?>(AddExecute,AddCanExecute);

its called only once and parameter is null (while textBlock shows proper ID value). CanExecute is called before ID property is called (checked with debugger). Seems like before binding to actual parameter wpf is invoking canExecute and forgets about it. Once binding finished and proper value loaded it doesn't call CanExecute again.

As a workaround I can use command with only execute delegate:

Add = new DelegateCommand<int?>(AddExecute);

AddExecute is invoked with correct ID value and is working perfectly. But I still want to use CanExecute functionality. Any ideas?

Tadich answered 17/11, 2009 at 13:15 Comment(0)
R
4

In this scenario, it's better to call the RaiseCanExecuteChanged() on the property used as a parameter for the Command. In your case, it would be the ID property in your ViewModel (Or whichever DataContext you're using).

It would be something like this:

private int? _id;
public int? ID
{
    get { return _id; }
    set
    {
        _id = value;
        DelegateCommand<int?> command = ((SomeClass)CalcEditView.DataContext).Add;
        command.RaiseCanExecuteChanged();
    }
}

The effect will be the same as your solution, but it keeps the Command logic out of code-behind.

Ribaldry answered 14/10, 2011 at 9:50 Comment(0)
K
2

You can try to use CommandManager.InvalidateRequerySuggested to force an update.

Kerbela answered 17/11, 2009 at 13:21 Comment(0)
A
1

I use parameter as object and then cast it back to int.

Add = new DelegateCommand<object>(add, canAdd);

and in add method

void add(object parameter){
    int id = Convert.ToInt32(parameter);

    //or simply

    int id2 = (int)parameter;

    //...
    //  do your stuff
    //...
}
Artemus answered 4/1, 2015 at 11:48 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.