pretty printing nested vectors

Question

I have the following code to pretty-print generic vectors -:

// print a vector
template<typename T1>
std::ostream& operator <<( std::ostream& out, const std::vector<T1>& object )
{
    out << "[";
    if ( !object.empty() )
    {
        std::copy( object.begin(), --object.end(), std::ostream_iterator<T1>( out, ", " ) );
        out << *--object.end(); // print the last element separately to avoid the extra characters following it.
    }
    out << "]";
    return out;
}  

I am getting a compiler error if I try to print a nested vector from it.

int main()
{
    vector<vector<int> > a;
    vector<int> b;
    // cout << b ; // Works fine for this
    cout << a; // Compiler error
}  

I am using GCC 4.9.2 with the -std=c++14 flag.

The error message given by the compiler is -:

no match for 'operator<<' (operand types are
'std::ostream_iterator<std::vector<int>, char, std::char_traits<char>::ostream_type {aka std::basic_ostream<char>}' and 'const std::vector<int>')  

Mot

Answer 1

std::copy( object.begin(), --object.end(), std::ostream_iterator<T1>( out, ", " ) );

You are using copy to ostream iterator which is not defined for vector of std::vector<>. One work around is to implement operator << in terms of operator << of children.

if ( !object.empty() )
{
    //std::copy( object.begin(), --object.end(), std::ostream_iterator<T1>( out, ", " ) );
    for(typename std::vector<T1>::const_iterator t = object.begin(); t != object.end() - 1; ++t) {
        out << *t << ", ";
    }
    out << *--object.end(); // print the last element separately to avoid the extra characters following it.
}

Live example here

This method will not work for the same reason for std::vector<my_type> if opeartor << is not defined for class my_type

Anacreontic

Answer 2

Just using a normal forloop instead of std::copy would solve this issue. As @Mohit suggested, the ostream iterator is not defined for nested vectors.

#include <iostream>
#include <vector>
#include <iterator>
#include <algorithm>
#include <functional>
using namespace std;

// print a vector
template<typename T1>
std::ostream& operator <<( std::ostream& out, const std::vector<T1>& object )
{
    out << "[";
    if ( !object.empty() )
    {
        for(typename std::vector<T1>::const_iterator
            iter = object.begin();
            iter != --object.end();
            ++iter) {
                out << *iter << ", ";
        }
        out << *--object.end();
    }
    out << "]";
    return out;
}

int main() {
    std::vector<std::vector<int> > a;
    std::vector<int> b;
    b.push_back(1);
    b.push_back(2);
    std::vector<int> c;
    c.push_back(3);
    c.push_back(4);
    std::cout << b << std::endl;
    std::cout << c << std::endl;
    a.push_back(b);
    a.push_back(c);
    cout << a; // Compiler error
    return 0;
}

Output would look like this:

[1, 2]
[3, 4]
[[1, 2], [3, 4]]

Icily