C++: How can i create a function that accepts concatenated strings as parameter?

Question

Can i design my logging-function in a way, that it accepts concatenated strings of the following form using C++?

int i = 1;
customLoggFunction("My Integer i = " << i << ".");

.

customLoggFunction( [...] ){
    [...]
    std::cout << "Debug Message: " << myLoggMessage << std::endl << std::endl
}

Edit:

Using std::string as the attribute to the function works for the concatenated string, but then a passed non-concatenated string like customLoggFunction("example string") produces a compile-time error saying the function is not applicable for char[]. When i overload the function in the following way...

customLoggFunction(std::string message){...}
customLoggFunction(char message[]){...}

... the concatenated strings seize to work.

I uploaded the code: http://coliru.stacked-crooked.com/a/d64dc90add3e59ed

Shirleyshirlie

Possible duplicate of How to concatenate a std::string and an int? – Finland

Hoe about using std::string? Then you can do e.g. customLoggFunction("My Integer i = " + std::to_string(i) + "."); – Desired

it's not about the function, what you want is about strings and operators. – Chunchung

Your method just needs to accept a string. It's absolutely irrelevant to the function how the string it receives was constructed. See the dup for how to concatenate strings and ints in C++. – Finland

This works for the concatenated string, but then it doesn't work when i pass a non-concatenated string like customLoggFunction("example string"). I get a compile time error saying the function is not applicable for char[]. Then when i overload with char[] the first option doesn't work. – Shirleyshirlie

I don't think you can do exactly that with a function. A macro, yes. Otherwise you can create a class object that overloads operator<< but it's non-trivial. – Langelo

"Using std::string as the attribute to the function works for the concatenated string, but then a passed non-concatenated string like customLoggFunction("example string") produces a compile-time error" Can't reproduce: coliru.stacked-crooked.com/a/d54abfc020c8d1b9 – Backstitch

Have a look @Backstitch : coliru.stacked-crooked.com/a/d64dc90add3e59ed – Shirleyshirlie

@RicoChr. The parameter has to be const: const char message[]. – Backstitch

Holy .... Black Cat. C++ Noob mistake :D Thank you very much. This platform and it's people are awesome... – Shirleyshirlie

@Backstitch it still doesn't work. What the heck is wrong with C++, this should be such a basic task.... – Shirleyshirlie

@RicoChr. Alright, post the last version of your code. – Backstitch

coliru.stacked-crooked.com/a/87667287543ad02a – Shirleyshirlie

Answer 1

It's impossible to do with the exact syntax you asked for unless you resort to macros.

But if you don't mind replacing << with ,, then you can do following:

#include <iostream>
#include <string>
#include <sstream>

void log_impl(const std::string &str)
{
    std::cout << str;
}

template <typename ...P> void log(const P &... params)
{
    std::stringstream stream;

    (stream << ... << params);
    // If you don't have C++17, use following instead of the above line:
    // using dummy_array = int[];
    // dummy_array{(void(stream << params), 0)..., 0};

    log_impl(stream.str());
}

int main()
{
    log("1", 2, '3'); // prints 123
}

Backstitch

i'll check this, looks nice. – Shirleyshirlie

I get an error: parameter packs not expanded with ‘...’: (stream << this->title << params); Did i miss something? – Shirleyshirlie

Are you compiling with C++17 @RicoChr. since it seems to use the parameter expansion in a fold expression if I'm not mistaken. – Aphrodite

I'm using this: gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 Copyright (C) 2015 Free Software Foundation, Inc. You tell me :D Sorry... But i'd say: No – Shirleyshirlie

@RicoChr. I've added a pre-c++17 alternative. – Backstitch

Answer 2

For trivial projects this is one of the few things I use a MACRO for. You can do something like this:

#define LOG(m) do{ std::cout << timestamp() << ": " << m << '\n'; }while(0)

// ...

LOG("error: [" << errno "] " << filename << " does not exist.");

Generally MACROS should be avoided but there is no other way to get precisely this with a standard function. So...

Note: The empty condition do{...}while(0) enables you to place the MACRO in places that a MACRO usually can't go if it contains multiple statements.

Langelo

Answer 3

You could do it by defining a new operator<<. From vague memory, implementing functions with these three signatures will do the trick:

std::string operator<<(const char * a, const std::string & b);
std::string operator<<(const std::string & a, const char * b);
std::string operator<<(const std::string & a, const std::string & b);

Each of them has to concatenate its arguments and return a std::string.

Howeever, it feels wrong. Goes against the grain of C++. I suggest a more C++-ish solution, namely to make your logger into a class, and write operator<<() members for that class, so you can run

customLog << "My Integer i = " << i << "." << "\n";

Ambrosio

this seems legit and comparable to the std::cout implementation, i'll try that. Thanks – Shirleyshirlie

Answer 4

One approach is a simple utility class that uses a standard stream in a templated member function:

class LogStream {
    public:
        template <class T> LogStream& operator << (const T& rhs) {
            stream << rhs;
            return *this;
        }

    private:
        std::stringstream stream;
};

The stream member doing all the work is then used in the destructor,

~LogStream() {
    std::cout << stream.str() << std::endl;
}

and you can create temporary objects for passing your arguments to be concatenated:

LogStream() << "anything with std::ostream operator: " << 1.2345 << ' ' << std::hex << 12;

Additional state (e.g. a log level) can be passed to the constructor, often accompagnied by convenience functions like LogStream debug() { return LogStream(...); }. When you reach a certain point of sophistication though, you might want to switch to a logging library of course.

Seta