FTPClient corrupts the images while uploading to ftp server on android?

Question

I'm trying to upload images to a FTP server (on my local PC) from Android Phone (HTC Desire HD). Images are going to FTP server but they are corrupted.

And the method (ftpClient.storeFile()) throws IOException (Bad File Number)

Please help me.

This is the corrupted image link:

http://imageshack.us/photo/my-images/820/komikb.jpg/

And this is the code:

FTPClient ftpClient = new FTPClient();
    try {
        ftpClient.connect("192.168.2.14");
        ftpClient.setFileType(FTP.BINARY_FILE_TYPE);
        ftpClient.setFileTransferMode(FTP.BINARY_FILE_TYPE);
        ftpClient.setSoTimeout(10000);
        ftpClient.enterLocalPassiveMode();
        if(ftpClient.login("Administrator", "xxxx"))
        {
            File sFile=new File("mnt/sdcard/DCIM/komik.jpg");
            FileInputStream fs= new FileInputStream(sFile);
            String fileName = sFile.getName();
            Boolean result = ftpClient.storeFile("/ftpfile.atspace.co.uk/" + fileName, fs);
            String has = "";
        }
    } catch (IOException e) {
        // TODO Auto-generated catch block
        e.printStackTrace();
    }

Halves

I'd say it got shortened by a number of bytes, not really corrupted. – Saprophagous

+1 for the excellent circle on the (otherwise lovely) hydrangea. – Heckle

Is it a repeatable problem? Does that file always get corrupted identically? Do other files get similarly cropped / cut / mangled? – Heckle

there is no if the file is image. But if the file type is audio, audio file didn't play. – Halves

yes this is a repeatable problem. I tried 2 type of file such as audio and image. Also I tried different images – Halves

could it be that you got bitten by issues.apache.org/jira/browse/NET-409 ? – Saprophagous

@osman: Does the link that fvu posted above apply to your situation? – Apropos

thank you so much.thank you so much.thank you so much.Problem is solved. everybody thank you:) – Halves

@osman: Please explain how the problem was solved. It might help others with the same problem. You can do this by adding an answer yourself explaining what the issue was. – Apropos

Answer 1

Problem is solved. FTPClient class has "last packet data loss bug". But this was solved with 3.0.1 23.05.2011 release.

You can see from detailed explanation about bug: https://issues.apache.org/jira/browse/NET-409

You can download fixed relea https://repository.apache.org/content/repositories/snapshots/commons-net/commons-net/3.0.1-SNAPSHOT/

Halves

Hi osman i am using 3.0.1 with the code you have written above but it is not working for me. The image is getting uploaded but corrupted . png image not even displaying . Can you plz guide me??..Thanks – Swob

Hi sujit, apache FTPClient has lots of bugs. This problem was solved. Another problems appeared later and I start using ftp4j. This is the link: sauronsoftware.it/projects/ftp4j I suggest you to use this component. – Halves

are you sure that this ftp4j not raise problem? – Idalia

Answer 2

Apache FTP Client has several outstanding issues with this. Below are instructions on how to use Ftp4J to effectively handle ftp programatically though java.

Download Ftp4J: http://www.sauronsoftware.it/projects/ftp4j/download.php

Then in your IDE:

import java.io.File;
import java.io.IOException;

import it.sauronsoftware.ftp4j.FTPAbortedException;
import it.sauronsoftware.ftp4j.FTPClient;
import it.sauronsoftware.ftp4j.FTPDataTransferException;
import it.sauronsoftware.ftp4j.FTPException;
import it.sauronsoftware.ftp4j.FTPIllegalReplyException;

public class FTP4J {

    /**
     * @param args
     * @throws FTPAbortedException 
     * @throws FTPDataTransferException 
     * @throws FTPException 
     * @throws FTPIllegalReplyException 
     * @throws IOException 
     * @throws IllegalStateException 
     */
    public static void main(String[] args) throws IllegalStateException, IOException, FTPIllegalReplyException, FTPException, FTPDataTransferException, FTPAbortedException {
        FTP4J ftp= new FTP4J();
        ftp.transfer();
    }

    private void transfer() throws IllegalStateException, IOException, FTPIllegalReplyException, FTPException, FTPDataTransferException, FTPAbortedException{
        FTPClient client = new FTPClient();
        client.connect("192.168.0.1"); //conect to FTP server (in my case a vsftp on centos 6.4)
        client.login("admn", "admn123");//login to FTP Server
        client.changeDirectory("/usr/share/tomcat/webapps/imgs/"); //tell FTP4J where on the Ftp Server to send your file that you want to upload.
        File fileUpload = new File ("C:\\Users\\ih8w8\\Pictures\\1.jpg"); //point FTP4J to the file you want to upload
        client.upload(fileUpload); //upload it
        client.disconnect(true); //close connection (note: you could also log out first, then disconn if youre not in a test env)
    }

}

Pointblank

How do you specify the name of the file you are uploading? – Guimpe