Feed rendered jsp pages through htmltidy
Asked Answered
C

3

7

I have a Java project running on Glassfish that renders some ugly looking HTML. Its a side effect from using various internal and external JSP libraries. I would like to set up some sort of post-render filter that would feed the final HTML through HTMLTidy so that the source is nice and neat to aid debugging. Is this possible?

Is there a built in mechanism to perform some action after the server renders the JSPs into HTML? Can that action get the generated HTML as a string and manipulate it? Is there some easy built-in option to do this without extra coding?

Colter answered 2/2, 2010 at 18:41 Comment(0)
L
5

JTidyFilter

Lamarckian answered 2/2, 2010 at 18:45 Comment(1)
I'd also like to note that JTidyFilter is still a bit rough with no formal release. You must download it from the JTidy nightlies at: jtidy.sourceforge.net/nightlyColter
B
3

This behaviour can also be eliminated to a certain degree by setting the JSP 2.1 property trimDirectiveWhitespaces to true. This can be enabled in individual JSP files by:

<%@page trimDirectiveWhitespaces="true" %>

Or on all JSP files by the following entry in web.xml (which needs to be declared Servlet 2.5!):

<jsp-config>
    <jsp-property-group>
        <url-pattern>*.jsp</url-pattern>
        <trim-directive-whitespaces>true</trim-directive-whitespaces>
    </jsp-property-group>
</jsp-config>

In pre-JSP 2.1 containers or in JSP 2.1 containers which actually doesn't support this for some internal reasons, such as Tomcat, you need to consult its JspServlet documentation for any initialization parameters. In for example Tomcat, you can configure it as well by setting the trimSpaces init-param of JspServlet to true in Tomcat's /conf/web.xml:

<init-param>
    <param-name>trimSpaces</param-name>
    <param-value>true</param-value>
</init-param>

Noted should be that the both approaches doesn't really "reformat" the HTML code. It actually only trims the whitespace which is left by taglibs and scriptlets. Also see this Sun article. So for example the following..

<ul>
    <c:forEach items="${list}" var="item">
        <li>${item}</li>
    </c:forEach>
</ul>

..would basically end up in

<ul>
        <li>item1</li>
        <li>item2</li>
        <li>item3</li>
</ul>

Thus with double indentation. You can actually workaround this by reformatting the code as such that JSP tags are half-indented:

<ul>
  <c:forEach items="${list}" var="item">
    <li>${item}</li>
  </c:forEach>
</ul>

But I think the JTidyFilter is easier here :)

Boarish answered 2/2, 2010 at 20:15 Comment(0)
C
0

If you can alter control flow so that you get the html output before it's returned to the browser, then jtidy may help you.

I would view this as a worst-case fix though. In the long run, what should help more is to separate your html generating code and refactor that. Even in large, complex projects, you should be able to do this in small pieces and you'll get a gradual improvement. Otherwise, if the your problems grow to the point where tidy can't help, you'll be back where you started (and with even more unwieldily code to deal with).

Coworker answered 2/2, 2010 at 18:46 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.