Generic class that conforms to Comparable in Swift
Asked Answered
Y

2

7

I'm attempting to create a simple generic node class that conforms to the Comparable protocol so that I can easily compare nodes without accessing their key. When I attempt to write the < and == functions, however, the compiler doesn't seem to like it. The < and == functions expect a type when defining the Node parameters. This was simple in Java where you defined equality and < internally to the class. Swift asks for it globally. Any thoughts ?

Example:

func < (lhs:Node<E:Comparable>, rhs:Node<E:Comparable>) -> Bool {
    return lhs.key < rhs.key
}


func == (lhs:Node<E:Comparable>, rhs:Node<E:Comparable>) -> Bool {
    return lhs.key == rhs.key
}


class Node<D:Comparable>: Comparable {

    var key: D!
    var next:Node?
    var prev:Node?

    init( key:D ) {

        self.key = key
    }
}
Yuu answered 29/7, 2014 at 21:54 Comment(0)
R
9

You're close! The Node class already specifies that for Node<D>, D must conform to Comparable. Therefore, Node<E: Comparable> in the decl for == and < is redundant. Instead, you want to restrict the types that the operators can be invoked upon:

func < <E: Comparable>(lhs: Node<E>, rhs: Node<E>) -> Bool {
    return lhs.key < rhs.key
}


func == <E: Comparable>(lhs: Node<E>, rhs: Node<E>) -> Bool {
    return lhs.key == rhs.key
}

class Node<D: Comparable>: Comparable {

    var key: D!
    var next: Node?
    var prev: Node?

    init(key: D) {
        self.key = key
    }
}
Rose answered 29/7, 2014 at 22:3 Comment(1)
I tried that earlier actually, and compiler complained "Use of undeclared identifier type 'E'" I also tried replacing the generic argument with AnyObject:Comparable but no dice.Yuu
F
2

You were very close. Small syntax issue Try this:

class Node<D:Comparable>: Comparable {

    var key: D!
    var next:Node?
    var prev:Node?

    init( key:D ) {

        self.key = key
    }

}

func < <E:Comparable> (lhs:Node<E>, rhs:Node<E>) -> Bool {
    return lhs.key < rhs.key
}

func == <E:Comparable> (lhs:Node<E>, rhs:Node<E>) -> Bool {
    return lhs.key == rhs.key
}
Fidelity answered 29/7, 2014 at 22:14 Comment(0)

© 2022 - 2024 — McMap. All rights reserved.