The error output by command setx is caused by wrong usage of the quotes on assigning the string to variable value
.
The command is set and the parameter is variable=value
. As for most commands and applications it is possible and often required to surround a parameter with double quotes if containing 1 or more spaces or any other character from this list: &()[]{}^=;!'+,`~
. Those characters are displayed on last help page output by running in a command prompt window cmd /?
or help cmd
.
But wrong is here:
set value="Hello world"
With first double quote after the equal sign the entire parameter variable=value
of command set is not enclosed in double quotes.
This results in interpreting the double quotes as part of the string to assign to variable with name value
. Everything from the equal sign to end of line including the double quotes and possibly existing trailing spaces and horizontal tabs is assigned here to variable value
instead of just the string Hello world
as expected.
On expanding the line
setx -M srijani "%srijani%;%value%"
the result is therefore:
setx -M srijani "Value of variable srijani;"Hello world""
And command setx interprets the wrong quoted parameter as syntax error.
Correct would be using:
set "value=Hello world"
Now the entire parameter of command set is enclosed in double quotes. Therefore ignored on parsing the line are:
- all spaces/tabs between command set and the first double quote,
- the first double quote,
- the last double quote,
- and all perhaps existing spaces/tabs after last double quote.
So just Hello world
is assigned to a variable with name value
.
For more details about correct assignment of a string to an environment variable read answer on Why is no string output with 'echo %var%' after using 'set var = text' on command line? It contains also a simple demo batch code.
Some more information:
How an argument string containing 1 or more quotes somewhere in the middle is interpreted depends on command respectively application. The behavior on interpreting an argument with 1 or more "
within an argument string can vary depending on used compiler as explained in an answer on batch file: list rar file in specific folder and write result into text file and of course the source code of the command / application.
For most commands and applications the correct syntax is:
command "parameter in quotes"
"Path to application\app.exe" "parameter in quotes"
But there are applications which require quotes in the middle of an argument string. An example of such an application is Windows Explorer.
The following syntax is required to open an Explorer window from within a batch file with current directory displayed in window.
explorer.exe /e,"%CD%"
Not working are:
explorer.exe "/e,%CD%"
explorer.exe /e "%CD%"
So explorer.exe
requires that the directory to open is specified after /e,
with quotes in the middle of parameter string or it interprets "/e,%CD%"
respectively "/e %CD%"
as name of the directory with path to display in Explorer window.
See also SS64 - Windows Explorer command-line options.
set variable="value"
instead ofset "variable=value"
. See for example Why is no string output with 'echo %var%' after using 'set var = text' on command line? for an explanation of the difference on where first quote is specified on line with command SET. – Habaneraset "variable=value"
does not include the surrounding quotes in the value, so you need to care about them only when expanding (reading) the value like"%variable%"
, so any code becomes more consistent in terms of quotation... – Opaline