Setting ModelState values in custom model binder
Asked Answered
B

1

17

I am using custom model binder in ASP.NET MVC 2 that looks like this:

    public override object BindModel(ControllerContext controllerContext, ModelBindingContext bindingContext)
    {
        if (controllerContext == null)
        {
            throw new ArgumentNullException("controllerContext");
        }
        if (bindingContext == null)
        {
            throw new ArgumentNullException("bindingContext");
        }

        BaseContentObject obj = (BaseContentObject)base.BindModel(controllerContext, bindingContext);
        if(string.IsNullOrWhiteSpace(obj.Slug))
        {
            // creating new object
            obj.Created = obj.Modified = DateTime.Now;
            obj.ModifiedBy = obj.CreatedBy = controllerContext.HttpContext.User.Identity.Name;
            // slug is not provided thru UI, derivate it from Title; property setter removes chars that are not allowed
            obj.Slug = obj.Title;
            ModelStateDictionary modelStateDictionary = bindingContext.ModelState;
            modelStateDictionary.SetModelValue("Slug", new ValueProviderResult(obj.Slug, obj.Slug, null));
...

When I get back from this binder into controller action, my business object that is provided as a parameter to the action is correctly altered (the lines obj.Created = .... work).

However, the ModelState is not updated. I know this because I have Required on my business object's Slug property and although I altered ModelStateDictionary in my custom model binder, providing a Slug to it (as you can see above), the ModelState.IsValid is still false.

If I put ModelState["Slug"] in my Watch window in Debug session, it says it has Errors (1), so apparently it is empty and as such fails.

How can I correctly alter the ModelState inside the custom model binder code?

Bulla answered 6/4, 2010 at 21:47 Comment(0)
B
23

Apparently there is no way to revalidate the ModelState once you change a value of some key. The IsValid remains false because setting a new value to some key does not trigger revalidation.

The solution is to first remove the key that triggered IsValid to be false and recreate it and assign the value to it. When you do that the ModelState automatically revalidates and if everything is fine, IsValid returns true.

Like this:

bindingContext.ModelState.Remove("Slug");
bindingContext.ModelState.Add("Slug", new ModelState());
bindingContext.ModelState.SetModelValue("Slug", new ValueProviderResult(obj.Slug, obj.Slug, null));
Bulla answered 7/4, 2010 at 12:37 Comment(2)
Your solution needs to be sticky at stackoverflow. I have been searching and experimenting high and low until I found this of yours. I guarantee you, not many people know of this trick. You saved my days! Thank you!Unpredictable
I tried your solution, and it sorta worked for my situation. Could you take a look at my question at #23146280 ? Thank you!Unpredictable

© 2022 - 2024 — McMap. All rights reserved.