ASP.NET MVC Validationsummary with excludePropertyErrors = true renders empty if the model is invalid

Question

Say you have a standard ValidationSummary:

<%: Html.ValidationSummary(excludePropertyErrors: true) %>

If the ModelState contains model errors for properties but not for the model itself the ValidationSummary renders the following HTML:

<div class="validation-summary-errors"><ul><li style="display:none"></li></ul></div>

Which is displayed as an empty list but is still visible because of the red border around the list. This seems to be a bug to me. Can I turn off that the ValidationSummary helper will ever render an empty list?

Siren

Answer 1

Similar to usr's answer, I fixed this with the following:

public static IHtmlString FixedValidationSummary(this HtmlHelper htmlHelper)
{
    return htmlHelper.FixedValidationSummary(false);
}

public static IHtmlString FixedValidationSummary(this HtmlHelper htmlHelper,
    bool excludePropertyErrors)
{
    var result = htmlHelper.ValidationSummary(excludePropertyErrors);
    return result == null || result.ToString().Contains("display:none") ? null : result;
}

This way I don't have to actually fork the original.

Agreed, though, this is very annoying.

Unprofessional

Answer 2

After I found out that there is no solution by looking at the source I solved the problem by forking the MVC version of the code and modifying one line.

Siren

You only have to fork 3 functions. – Siren

Answer 3

Another variation of the fix with Bootstrap classes is:

public static class ValidationSummaryExtensions
{
    public static MvcHtmlString CleanValidationSummary(this HtmlHelper htmlHelper, bool excludePropertyErrors, string message = null)
    {
        if(htmlHelper == null) throw new ArgumentNullException("htmlHelper");

        MvcHtmlString validationSummary = null;
        if (htmlHelper.ViewData.ModelState.ContainsKey(string.Empty))
        {
            var htmlAttributes = new { @class = "alert alert-danger" };
            validationSummary = htmlHelper.ValidationSummary(excludePropertyErrors, message, htmlAttributes);
        }

        return validationSummary;
    }
}

Mistake

Answer 4

Another workaround is to move the style to the div. Here's the CSS:

div.validation-summary-valid {
    display: none;
}

When the summary returns with no errors the div is not displayed. When there are errors the class is automatically changed to validation-summary-errors.

Ingenuity