Android setText / R.string / values

Question

I am having trouble with setting text in a text view with format and multiple values.

holder.car.setText(R.string.mycar + lm.getCarName() + R.string.year + lm.getYear());

this is giving me " 2143545 Camero 2143213 1977 "

I have tried few other "solutions" from the web

holder.car.setText(getString(R.string.mycar) + lm.getCarName() + getString(R.string.year) + lm.getYear());  << not work, getString undefine>>

I even tried String.valueOf(R.string.mycar); getResources().getText(R.String.mycar), still it didn't work.

It would be great if someone can help me, thanks

Handy

what does "still not work" means? What do you expect? – Doan

It's because R.string.mycar is an int that refers to a resource. It's not the actual resource. @user1417127 's answer looks good. It fetches the actual string resource for you – Extraterritorial

use context.getResources.getString(R.string.xyx). – Queri

Answer 1

Try this

holder.car.setText(getResources().getString(R.string.mycar));

Ullman

Answer 2

I think you're trying to use parameters in your string.

Try this:

<string name="mycar">Car: %1$s Year: %2$s</string>

String mycar = getString(R.string.mycar);
mycar = String.format(mycar, lm.getCarName(), lm.getYear());

You should get:

Car: Camaro Year: 1977

Enforcement

Answer 3

If you want to set your textview just a string from your string.xml file,

mytextview.setText(R.String.mycar);

If you want to set your textview with combination of some strings or integers, (better than first way)

int number=5;

mytextview.setText(getResources().getString(R.String.mycar) + " " +number + " " + getResources().getString(R.String.mysecondcar));

Aldosterone

How to deal with the Android Studio warning: "Do no concanate text displayed with setText. Use Resource string with place holders" ? – Frisbie

Answer 4

R.string.mycar and R.string.year are only IDs for resources. For this reason you get the numbers (IDs are numeric).

To get string from resources you need to use this construction:

String myCar = getResources().getString(R.string.mycar);

and now the myCar variable holds the string you put in strings.xml file under the mycar name.

the method getResources() belongs to Context. If you run your code outside an Activity, use the context instance to get the string, like this:

String myCar = context.getResources().getString(R.string.mycar);

Bicyclic

Answer 5

Try this. If you're fetching string in class without extending Activity Get using your Context

holder.car.setText(context.getResources().getString(R.string.mycar));

If you're extending Activity

holder.car.setText(yourActivity.this.getResources().getString(R.string.mycar));

Hope this helps you..

Historiographer

instead of context can we write getActivit() ? are there any problem – Periotic

@Periotic It depends on your requirement. Read the document here – Historiographer

Answer 6

You have to retrieve your resources first, and the call the medthod getString(int), not getText, has you have put.

So, it should be:

getResources().getString(R.String.mycar);

Synergistic

Answer 7

The R class contains kind of pointers to your ressources, so you can not directly use them, use getResources().getString(), as others say.

Adventist

Answer 8

You have to use

context.getText(R.string.mycar);

just.
The context is the activity that is passed to the adapter.
It works for me.

Scoff