As noted in other answers, your code is not working primarily because String.replace(...)
does not change the target String
. (It can't - Java strings are immutable!) What replace
actually does is to create and return a new String
object with the characters changed as required. But your code then throws away that String
...
Here are some possible solutions. Which one is most correct depends on what exactly you are trying to do.
// #1
text = text.replace("\n", "");
Simply removes all the newline characters. This does not cope with Windows or Mac line terminations.
// #2
text = text.replace(System.getProperty("line.separator"), "");
Removes all line terminators for the current platform. This does not cope with the case where you are trying to process (for example) a UNIX file on Windows, or vice versa.
// #3
text = text.replaceAll("\\r|\\n", "");
Removes all Windows, UNIX or Mac line terminators. However, if the input file is text, this will concatenate words; e.g.
Goodbye cruel
world.
becomes
Goodbye cruelworld.
So you might actually want to do this:
// #4
text = text.replaceAll("\\r\\n|\\r|\\n", " ");
which replaces each line terminator with a space1. Since Java 8 you can also do this:
// #5
text = text.replaceAll("\\R", " ");
And if you want to replace multiple line terminator with one space:
// #6
text = text.replaceAll("\\R+", " ");
1 - Note there is a subtle difference between #3 and #4. The sequence \r\n
represents a single (Windows) line terminator, so we need to be careful not to replace it with two spaces.
myString.trim().replaceAll("[\n]{2,}", "\n")
Or replace with a single spacemyString.trim().replaceAll("[\n]{2,}", " ")
– Which